-
Notifications
You must be signed in to change notification settings - Fork 264
Change Statement unevict method to call UpdateTask #912
Conversation
…ask. This is needed in order to 'undo' the changes that were created during the call to 'evict' method (currently the node.Releasing value is wrong and will have the value as if the job was evicted, even if 'unevict' was called). When AddTask is called an error is returned because the task already exists in this node, and the Releasing value isn't set to the right value as if the job was never evicted.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @yodarshafrir1! |
Hi @yodarshafrir1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @hex108 |
I signed it |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, yodarshafrir1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This change ensures that when
unevict
is called the value ofnodeInfo.Releasing
will be updated as if the task was evicted.Before this fix, because the task exists on the current
nodeInfo
, every timeunevict
is called theReleasing
value of the nodeInfo isn't updated and the value remains same as if the task wasevicted
Why does it happen:
This happens because
unevict
callsAddTask
:AddTask
will throw an error because this task already exists under the current nodeInfo and therefore will not update theReleasing
field as if the current task isRunning
Issue: #907