Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PULL_REQUEST_TEMPLATE.md to a valid place #51

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Move PULL_REQUEST_TEMPLATE.md to a valid place #51

merged 1 commit into from
Dec 13, 2021

Conversation

sanposhiho
Copy link
Member

Hello.
This PR just moves PULL_REQUEST_TEMPLATE.md to the valid place (under .github/).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 8, 2021
@sanposhiho
Copy link
Member Author

/label tide/merge-method-squash
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Dec 8, 2021
@riita10069
Copy link
Member

@sanposhiho
Can I just LGTM this?

@riita10069
Copy link
Member

/lgtm

@sanposhiho
Copy link
Member Author

sanposhiho commented Dec 13, 2021 •
edited
Loading

@riita10069

Prow will label lgtm with it, but it seems that /ltgm from non-reviewers has no impact. 😢

/lgtm | Anyone, but triggers automation if a Reviewer or Approver uses it
https://kubernetes.io/docs/contribute/review/for-approvers/

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2021
@riita10069
Copy link
Member

Prow will label lgtm with it, but it seems that /ltgm from non-reviewers has no impact. 😢

Oh, yeah! I understand.

@k8s-ci-robot k8s-ci-robot merged commit a6582ef into kubernetes-sigs:master Dec 13, 2021
@riita10069
Copy link
Member

Well, it merged!

@sanposhiho
Copy link
Member Author

sanposhiho commented Dec 13, 2021 •
edited
Loading

Hmmmmm, it's bug on prow I think.

@sanposhiho
Copy link
Member Author

I'll report it and check if it is expected behavior or not

@riita10069
Copy link
Member

Thx!

@riita10069
Copy link
Member

member can do lgtm label reference of following
https://github.com/kubernetes/community/blob/master/community-membership.md#responsibilities-and-privileges

@sanposhiho
Copy link
Member Author

sanposhiho commented Dec 13, 2021 •
edited
Loading

Yes, but this doc says "Anyone, but triggers automation if a Reviewer or Approver". I think one of them is wrong.

/lgtm | Anyone, but triggers automation if a Reviewer or Approver uses it
https://kubernetes.io/docs/contribute/review/for-approvers/

@sanposhiho sanposhiho mentioned this pull request Dec 13, 2021
Closed
@sanposhiho
Copy link
Member Author

kubernetes/test-infra#24660

@sanposhiho
Copy link
Member Author

sanposhiho commented Dec 13, 2021 •
edited
Loading

@riita10069

Please don't add /lgtm on PRs from me until we can check if it is ok or not. 🙏
(prow will merge it if a PR is from approver.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adtac adtac Awaiting requested review from adtac

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@riita10069 riita10069

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanposhiho @k8s-ci-robot @riita10069