-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped versions of k8s dependencies and controller-runtime and k8s dependencies #217
Bumped versions of k8s dependencies and controller-runtime and k8s dependencies #217
Conversation
Thanks @NikhilSharmaWe - looks like there are some breaking API changes in kubectl / cli-utils. I'll take a look! cc @seans3 |
2ac9e49
to
2840bac
Compare
2840bac
to
de62e65
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
5d2c99e
to
bc4b28e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ddfe740
to
1b4b7a0
Compare
d7b9a74
to
8cdf972
Compare
8cdf972
to
ef06d86
Compare
ef06d86
to
7c332c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Great job @NikhilSharmaWe ! Not sure I have permissions for it, but:
/lgtm
/approve
@everettraven: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It could be any string, but when looking into the details of the I felt like Now that I think about it, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
Nice contribution @NikhilSharmaWe and @everettraven 🥇
We need to ping the Owners of this repo so that they can help us move forward.
/lgtm |
/lgtm @justinsb |
@justinsb could you take a look at this? We have a couple projects relying on this dependency to be upgraded to support k8s 1.24 before they can be upgraded. Thanks! |
/approve It already looks good for me, and I thinked it is also good to get review from other approver if possible. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atoato88, camilamacedo86, everettraven, NikhilSharmaWe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FYI we started to encounter an issue that seems to have been introduced in this PR: #224 Wondering if anyone can take a look. |
What this PR does / why we need it:
This PR bumps versions of k8s dependencies and controller-runtime and k8s dependencies to be compatible with https://github.com/kubernetes-sigs/kubebuilder.