Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use pre-built image for action #3

Conversation

DirectXMan12
Copy link
Contributor

This will use a prebuilt image that's automatically built for this
repository for each tag by GCB. This should speed up action execution a
bit.

The version in this repo will still run from the local code though, so
we can still fix bugs. That configuration lives in the action-nightly
subdirectory, and can also be referenced by external projects.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from Adirio and estroz October 1, 2020 19:06
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2020
@DirectXMan12 DirectXMan12 changed the title Use pre-built image for action 🌱 Use pre-built image for action Oct 1, 2020
@DirectXMan12 DirectXMan12 force-pushed the feature/prebuilt-image-for-action branch from cb7fde8 to 879afc8 Compare October 1, 2020 19:29
@DirectXMan12 DirectXMan12 changed the base branch from master to actions-test October 1, 2020 19:29
@DirectXMan12 DirectXMan12 changed the base branch from actions-test to master October 1, 2020 19:33
This will use a prebuilt image that's automatically built for this
repository for each tag by GCB.  This should speed up action execution a
bit.

The version in this repo will still run from the local code though, so
we can still fix bugs.  That configuration lives in the `action-nightly`
subdirectory, and can also be referenced by external projects.
@DirectXMan12 DirectXMan12 force-pushed the feature/prebuilt-image-for-action branch from 879afc8 to 1d9d3d3 Compare October 1, 2020 19:33
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4777888 into kubernetes-sigs:master Oct 1, 2020
@DirectXMan12 DirectXMan12 deleted the feature/prebuilt-image-for-action branch October 1, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants