pkg/plugin/utils: add tests to cover funcs

pkg/plugin/util/util_test.go

@@ -1,9 +1,12 @@
 /*
 Copyright 2022 The Kubernetes Authors.
+
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
+
     http://www.apache.org/licenses/LICENSE-2.0
+
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -21,42 +24,77 @@ import (
 	. "github.com/onsi/gomega"
 )
 
-var _ = Describe("InsertCode", Ordered, func() {
-	path := filepath.Join("testdata", "exampleFile.txt")
-	var content []byte
-
-	BeforeAll(func() {
-		err := os.MkdirAll("testdata", 0755)
-		Expect(err).NotTo(HaveOccurred())
-
-		if _, err := os.Stat(path); os.IsNotExist(err) {
-			err = os.WriteFile(path, []byte("exampleTarget"), 0644)
+var _ = Describe("Util Functions", func() {
+	Describe("RandomSuffix", func() {
+		It("should return a 4-letter string", func() {
+			suffix, err := RandomSuffix()
 			Expect(err).NotTo(HaveOccurred())
-		}
+			Expect(suffix).To(HaveLen(4))
+		})
 
-		content, err = os.ReadFile(path)
-		Expect(err).NotTo(HaveOccurred())
+		It("should return different values on multiple invocations", func() {
+			suffix1, _ := RandomSuffix()
+			suffix2, _ := RandomSuffix()
+			Expect(suffix1).NotTo(Equal(suffix2))
+		})
 	})
 
-	AfterAll(func() {
-		err := os.WriteFile(path, content, 0644)
-		Expect(err).NotTo(HaveOccurred())
+	Describe("GetNonEmptyLines", func() {
+		It("should return non-empty lines from a string", func() {
+			output := "line1\n\nline2\nline3\n\n"
+			lines := GetNonEmptyLines(output)
+			Expect(lines).To(Equal([]string{"line1", "line2", "line3"}))
+		})
 
-		err = os.RemoveAll("testdata")
-		Expect(err).NotTo(HaveOccurred())
+		It("should return an empty slice if the input is empty", func() {
+			lines := GetNonEmptyLines("")
+			Expect(lines).To(BeEmpty())
+		})
+
+		It("should handle strings with no line breaks", func() {
+			output := "singleline"
+			lines := GetNonEmptyLines(output)
+			Expect(lines).To(Equal([]string{"singleline"}))
+		})
 	})
 
-	DescribeTable("should not succeed",
-		func(target string) {
-			Expect(InsertCode(path, target, "exampleCode")).ShouldNot(Succeed())
-		},
-		Entry("target given is not present in file", "randomTarget"),
-	)
-
-	DescribeTable("should succeed",
-		func(target string) {
-			Expect(InsertCode(path, target, "exampleCode")).Should(Succeed())
-		},
-		Entry("target given is present in file", "exampleTarget"),
-	)
+	Describe("InsertCode", Ordered, func() {
+		path := filepath.Join("testdata", "exampleFile.txt")
+		var content []byte
+
+		BeforeAll(func() {
+			err := os.MkdirAll("testdata", 0755)
+			Expect(err).NotTo(HaveOccurred())
+
+			if _, err := os.Stat(path); os.IsNotExist(err) {
+				err = os.WriteFile(path, []byte("exampleTarget"), 0644)
+				Expect(err).NotTo(HaveOccurred())
+			}
+
+			content, err = os.ReadFile(path)
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		AfterAll(func() {
+			err := os.WriteFile(path, content, 0644)
+			Expect(err).NotTo(HaveOccurred())
+
+			err = os.RemoveAll("testdata")
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		DescribeTable("should not succeed",
+			func(target string) {
+				Expect(InsertCode(path, target, "exampleCode")).ShouldNot(Succeed())
+			},
+			Entry("target given is not present in file", "randomTarget"),
+		)
+
+		DescribeTable("should succeed",
+			func(target string) {
+				Expect(InsertCode(path, target, "exampleCode")).Should(Succeed())
+			},
+			Entry("target given is present in file", "exampleTarget"),
+		)
+	})
 })