Can I add spaces in kubebuilder comments? #3801
-
When setting up linters to some projects, I saw the following error:
Can I safely add a space between In the kubebuilder book, I saw comments in both formats, i.e., |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
Thank you for raise this one. kubebuilder/pkg/machinery/marker.go Line 57 in 2b25ade However, we have also controller-tools and seems that there all are with spaces: https://github.com/search?q=repo%3Akubernetes-sigs%2Fcontroller-tools%20%2F%2F%20%2Bkubebuilder%3A&type=code Due the linter issue raised by you, I think we can ensure that we have an space always, see: #3904 fell free to review this one. |
Beta Was this translation helpful? Give feedback.
-
We opened an PR to change it out, feel free to review. |
Beta Was this translation helpful? Give feedback.
Hi @mateusoliveira43
Thank you for raise this one.
I agree that we should have an standard and ensure that all places are in the same.
Currently, the markers scaffold by Kubebuilder CLI are without space see:
kubebuilder/pkg/machinery/marker.go
Line 57 in 2b25ade
However, we have also controller-tools and seems that there all are with spaces: https://github.com/search?q=repo%3Akubernetes-sigs%2Fcontroller-tools%20%2F%2F%20%2Bkubebuilder%3A&type=code
Due the linter issue raised by you, I think we can ensure that we have an space always, see: #3904
fell free to review this one.