Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make namespace configurable #1613

Closed
pigletfly opened this issue Jul 27, 2020 · 4 comments
Closed

Make namespace configurable #1613

pigletfly opened this issue Jul 27, 2020 · 4 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pigletfly
Copy link

/kind feature

Now we are using system namespace for CRD deployment in scaffolds, I think it's better to make it configurable.Because the default system namespace may not exists, and also we may want to put different CRDs in different namespaces.

@pigletfly pigletfly added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 27, 2020
@camilamacedo86
Copy link
Member

Hi @pigletfly,

Shows that when you run the make targets for the project it will scaffold a new namespace which is the "projectName"+"-system" and apply all manifest on it. So, the namespace will always exist since it is created as well.

Also, check that for v3 we will be able to configure the project name. See #1609.

However, users are able able to o customizations on their project Makefile as well. Please, let us know if it makes sense and if you still have seen something that could be addressed in the default behaviour. If yes, could you please describe what/where and provide use cases that justify the feature request?

@camilamacedo86
Copy link
Member

camilamacedo86 commented Aug 15, 2020

HI @pigletfly,

As described above with #1609 (valid just for v3+) allow users to configure the project name. The namespace is created via the default configuration and workflow by default always then the scenario default system namespace may not exists shows that not valid.

Feel free to test it with the master branch by using the v3+ plugin such as:

E.g:

kubebuilder init --plugins=go/v3-alpha --domain=tutorial.kubebuilder.io --project-version=3-alpha --repo=tutorial.kubebuilder.io/project --license apache2 --owner "The Kubernetes authors"

However, users are also able to customize their projects by updating the files scaffolded as the Makefile as please them to for example change the namespace where the project will be deployed.

So, your concern here shows addressed already and because of this, I am closing this RFE. However, feel free to re-open if you see that has something that could be addressed yet.

/close

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: Closing this issue.

In response to this:

/asign @camilamacedo86

HI @pigletfly,

As described above with #1609 (valid just for v3+) allow users to configure the project name. The namespace is created via the default configuration and workflow by default always then the scenario default system namespace may not exists shows that not valid.

Feel free to test it with the master branch by using the v3+ plugin such as:

E.g:

kubebuilder init --plugins=go/v3-alpha --domain=tutorial.kubebuilder.io --project-version=3-alpha --repo=tutorial.kubebuilder.io/project --license apache2 --owner "The Kubernetes authors"

However, users are also able to customize their projects by updating the files scaffolded as the Makefile as please them to for example change the namespace where the project will be deployed.

So, your concern here shows addressed already and because of this, I am closing this RFE. However, feel free to re-open if you see that has something that could be addressed yet.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86
Copy link
Member

/assign @camilamacedo86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants