cleanup-book: remove docs/book/src/migration/testdata

[camilamacedo86]

Closes: #1279

The mainly complain of #1279 were the outdated mock testdata in the book which was just used as an example over the final results of the migration from v1 o v2.

In this way, since the V1 is deprecated and no longer for too long then, shows quite safe to remove the old mock data that was just added as an illustration.

[camilamacedo86]

Hi @Adirio @mengqiy,

Could you please help by checking this one? Wdyt? Are you ok with?

[camilamacedo86]

Indirect deps which were updated with sigs.k8s.io/kubebuilder-declarative-pattern

[Adirio]

/hold

See #1279 (comment)

TLDR: Now that the purpose of the testdata folder is clear, IMHO we should not remove it.

[camilamacedo86]

HI @mengqiy @droot,

IHMO it is quite safe we remove the V1 example from the books since:

• V1 code is deprecated, no longer support and removed
• Users are still able to follow up on the steps. Note that the example do not add too much value at all to the migration guide. PS. If someone has a V1 project and would like to migrate, why is required to keep an example of a V1 project at all? What need this example is addressing?
• Also, since it uses dep and it is no longer a required at all then, the following error will be faced `

Cannot run program "/Users/camilamacedo/go/bin/dep" (in directory "/Users/camilamacedo/go/src/sigs.k8s.io/kubebuilder/docs/book/src/migration/testdata/gopath/project-v1"): error=2, No such file or directory

WDYT?

c/c @Adirio

[camilamacedo86]

/assign @droot

[camilamacedo86]

hi @pwittrock,

I saw that you have been helping with the reviews. really tks btw. 🥇 So, this one is a case that is ok to be merged but requires more opinions to reach a consensus. if you have time would be great get your input.

[camilamacedo86]

Hi, @gabbifish @pwittrock @DirectXMan12 it is open for a while. WDYT? Are you ok with we removing the mock data of v1 since it is no longer supported a while?

[camilamacedo86]

I am removing the
/hold cancel

Otherwise will be hard to get reviews.

[pwittrock]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86,pwittrock]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@camilamacedo86: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubebuilder-e2e-k8s-1-16-2	3da18c3	link	/test pull-kubebuilder-e2e-k8s-1-16-2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[camilamacedo86]

/test pull-kubebuilder-e2e-k8s-1-16-2