Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace links to godoc.org with links to pkg.go.dev #1588

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

knight42
Copy link
Member

@knight42 knight42 commented Jul 6, 2020

Signed-off-by: knight42 anonymousknight96@gmail.com

  1. fix outdated links, like https://godoc.org/github.com/kubernetes-sigs/controller-runtime/pkg/cache#MultiNamespacedCacheBuilder, by changing them to something like https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/cache?tab=doc#MultiNamespacedCacheBuilder
  2. replace links to godoc.org with links to pkg.go.dev
  3. remove trailing spaces

Signed-off-by: knight42 <anonymousknight96@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 6, 2020
@k8s-ci-robot k8s-ci-robot requested review from droot and pwittrock July 6, 2020 03:41
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 6, 2020
@knight42
Copy link
Member Author

knight42 commented Jul 6, 2020

/assign @estroz

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the links. All fine.
great catcher 👍

/approved

@camilamacedo86
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, knight42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
@knight42
Copy link
Member Author

knight42 commented Jul 7, 2020

/retest

@estroz
Copy link
Contributor

estroz commented Jul 7, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6ffec14 into kubernetes-sigs:master Jul 7, 2020
@knight42 knight42 deleted the doc/replace-godoc branch July 7, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants