🐛 fix: the CRD paths is only ../.. when is multigroup #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
camilamacedo86
changed the title
k8s-ci-robot
added
the
approved
camilamacedo86
force-pushed
the
fix-1673
branch
from
c6cee48 to
02e2756
Compare
camilamacedo86
force-pushed
the
fix-1673
branch
from
02e2756 to
b54106b
Compare
|
/test pull-kubebuilder-e2e-k8s-1-14-1 |
|
Hi @gabbifish, Could you please give a hand in the review of this one for we fix the issue? |
gabbifish
approved these changes
Sep 17, 2020
| @@ -138,7 +148,7 @@ var _ = BeforeSuite(func(done Done) { | |||
|
|
|||
| By("bootstrapping test environment") | |||
| testEnv = &envtest.Environment{ | |||
| CRDDirectoryPaths: []string{filepath.Join("..", "..", "config", "crd", "bases")}, | |||
| CRDDirectoryPaths: []string{filepath.Join({{ .CRDDirectoryRelativePath }}, "config", "crd", "bases")}, | |||
There was a problem hiding this comment.
I did not know this trick before--today I learned!
k8s-ci-robot
added
the
lgtm
|
/test pull-kubebuilder-e2e-k8s-1-16-2 |
|
/test pull-kubebuilder-e2e-k8s-1-15-3 |
|
/test pull-kubebuilder-e2e-k8s-1-14-1 |
1 similar comment
|
/test pull-kubebuilder-e2e-k8s-1-14-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1673
If is multigroup the path needs more one ../ otherwise not.