-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ not allow to init the project in a directory that is not cleaned (v3+ only) #1738
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:master
from
camilamacedo86:init-validation
Oct 23, 2020
Merged
✨ not allow to init the project in a directory that is not cleaned (v3+ only) #1738
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:master
from
camilamacedo86:init-validation
Oct 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Oct 22, 2020
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 22, 2020
camilamacedo86
force-pushed
the
init-validation
branch
from
October 22, 2020 15:06
b6ddeae
to
af99c12
Compare
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Oct 22, 2020
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, pwittrock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
camilamacedo86
force-pushed
the
init-validation
branch
from
October 22, 2020 15:13
af99c12
to
0fd633b
Compare
k8s-ci-robot
removed
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Oct 22, 2020
prafull01
reviewed
Oct 22, 2020
camilamacedo86
force-pushed
the
init-validation
branch
2 times, most recently
from
October 22, 2020 18:54
f513f9e
to
261baf9
Compare
camilamacedo86
force-pushed
the
init-validation
branch
from
October 22, 2020 19:06
261baf9
to
e0a776b
Compare
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Oct 23, 2020
/test pull-kubebuilder-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not allow scaffold/init a project in a directory when it has other files already.
The only files that shows make sense be allowed are .gitignore and go.mod
Motivation
operator-framework/operator-sdk#4067