Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Remove install.sh #2256

Merged
merged 1 commit into from
Oct 14, 2021
Merged

🐛 Remove install.sh #2256

merged 1 commit into from
Oct 14, 2021

Conversation

swiftslee
Copy link
Contributor

@swiftslee swiftslee commented Jul 7, 2021 •
edited
Loading

Signed-off-by: yuswift yuswift2018@gmail.com

This pr adjusts scripts/install.sh for releases after v3. For releases before v3, it doesn't work. I see there already exists a document for installation, so I'm not sure if we need this script again. If not, I'm glad to remove it. I've tested on my local environment. If the users have used the script before, the new change will not affect the old dir, there will generate a new binary file called kubebuilder under the /usr/local/bin/ dir.
Usage:
bash scripts/install.sh

Fixes #2248

  • 🐛 (:bug:)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from Adirio and joelanford July 7, 2021 07:37
@k8s-ci-robot
Copy link
Contributor

Welcome @yuswift!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @yuswift. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2021
@swiftslee
Copy link
Contributor Author

/retitle Fix: adjust install.sh for releases after v3

@k8s-ci-robot
Copy link
Contributor

@yuswift: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle Fix: adjust install.sh for releases after v3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swiftslee swiftslee changed the title Fix: adjust install.sh for the latest release Patch fix: 🐛 (:bug:) adjust install.sh for releases after v3 Jul 7, 2021
@swiftslee swiftslee changed the title Patch fix: 🐛 (:bug:) adjust install.sh for releases after v3 - Patch fix: 🐛 (:bug:) adjust install.sh for releases after v3 Jul 7, 2021
@swiftslee swiftslee changed the title - Patch fix: 🐛 (:bug:) adjust install.sh for releases after v3 Patch fix: 🐛 Adjust install.sh for releases after v3 Jul 7, 2021
@swiftslee swiftslee changed the title Patch fix: 🐛 Adjust install.sh for releases after v3 🐛 (:bug:) Adjust install.sh for releases after v3 Jul 7, 2021
@swiftslee swiftslee changed the title 🐛 (:bug:) Adjust install.sh for releases after v3 🐛 Adjust install.sh for releases after v3 Jul 7, 2021
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2021
camilamacedo86
camilamacedo86 reviewed Jul 16, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yuswift,

This script is used only for the CI. Users should not use that to install the CLI.
However, if your changes does not broke the CI/prow jobs I am ok with

@swiftslee
Copy link
Contributor Author

swiftslee commented Jul 16, 2021 •
edited
Loading

Hi @yuswift,

This script is used only for the CI. Users should not use that to install the CLI.
However, if your changes does not broke the CI/prow jobs I am ok with

Does the ci only test v2? IMO, for v3 the script can't be executed successfully. Could you tell me where do we use the script in CI?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2021
@swiftslee swiftslee force-pushed the fix_install.sh branch 2 times, most recently from 814c830 to 9c620db Compare July 23, 2021 07:03
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2021
@swiftslee
Copy link
Contributor Author

Rebase done.

@swiftslee
Copy link
Contributor Author

friendly ping @camilamacedo86

camilamacedo86
camilamacedo86 reviewed Oct 2, 2021
View reviewed changes
scripts/install.sh Outdated
@@ -70,37 +70,31 @@ fi

KUBEBUILDER_VERSION=${KUBEBUILDER_VERSION#"v"}
KUBEBUILDER_VERSION_NAME="kubebuilder_${KUBEBUILDER_VERSION}"
KUBEBUILDER_DIR=/usr/local/kubebuilder
KUBEBUILDER_DIR=/usr/local/bin/kubebuilder

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to check where this script has been used.
Did you test these changes? Could you please add in the first comment how are you testing the changes and its result?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please take a look at the first comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it's not used anywhere. Sounds like we should remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@swiftslee
remove install.sh
631b627 
Signed-off-by: yuswift <yuswift2018@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 14, 2021
@swiftslee swiftslee changed the title 🐛 Adjust install.sh for releases after v3 🐛 Remove install.sh Oct 14, 2021
@estroz
Copy link
Contributor

estroz commented Oct 14, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, yuswift

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 29e317f into kubernetes-sigs:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz left review comments

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@Adirio Adirio Awaiting requested review from Adirio

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v3.1.0/install.sh : impossible to download "kubebuilder_3.1.0_linux_amd64.tar.gz"
4 participants
@swiftslee @k8s-ci-robot @camilamacedo86 @estroz