-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add todo(user) to make clear the need to optimize the values of the manager resources according to the needs #2365
Conversation
9ff1365
to
a85438f
Compare
… manager resources according to the needs
@@ -93,6 +93,8 @@ spec: | |||
port: 8081 | |||
initialDelaySeconds: 5 | |||
periodSeconds: 10 | |||
# TODO(user): Configure the resources accordingly to the project requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
# TODO(user): Configure the resources accordingly to the project requirements. | |
# TODO(user): Configure the resources accordingly based on the project requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
Add todo(user) to make clear the need to optimize the values of the manager resources according to the needs
Related to: #2347