Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix issue to scaffold same Kind for different groups with multi-group support by using group name in crd/patches and rbac editor/viewer manifests #2500

Merged
merged 1 commit into from
Feb 1, 2022
Merged

🐛 fix issue to scaffold same Kind for different groups with multi-group support by using group name in crd/patches and rbac editor/viewer manifests #2500

merged 1 commit into from
Feb 1, 2022

Conversation

rmb938
Copy link
Contributor

@rmb938 rmb938 commented Jan 30, 2022

Modification to include the group name in the crd patch and rbac editor/viewer file names. This is to prevent file naming conflicts when multiple groups have the same kind names.

This is to fix #2495

@k8s-ci-robot
Copy link
Contributor

Welcome @rmb938!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rmb938. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2022
@rmb938 rmb938 changed the title (:bug:) include group name in crd patches and rbac editor/viewer files 🐛 include group name in crd patches and rbac editor/viewer files Jan 30, 2022
@rmb938 rmb938 force-pushed the groupmanifestnames branch from 334da7c to 695795e Compare January 30, 2022 18:48
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 30, 2022
@rmb938 rmb938 force-pushed the groupmanifestnames branch from b7550a1 to d737834 Compare January 30, 2022 18:51
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2022
@rmb938
Copy link
Contributor Author

rmb938 commented Jan 30, 2022

I've split the commits into actual code changes vs test data being re-generated. Hopefully it makes it easier to review :)

@camilamacedo86
Copy link
Member

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2022
@camilamacedo86
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2022
camilamacedo86
camilamacedo86 requested changes Jan 31, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the terrific collab 🥇
Just a nit. We need to only change the path/name when is multigroup.
Could you please:

  • Apply the suggestions
  • Run make generate
  • Push the changes in 1 commit ( squashed )

For we are able to get these ones merged
Thank you a lot.

@rmb938 @camilamacedo86
include group name in crd patches and rbac editor/viewer files
02afb69 
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
@rmb938 rmb938 force-pushed the groupmanifestnames branch from d49ab87 to 02afb69 Compare January 31, 2022 23:03
@rmb938
Copy link
Contributor Author

rmb938 commented Jan 31, 2022

/retest

@rmb938
Copy link
Contributor Author

rmb938 commented Jan 31, 2022

ok @camilamacedo86 All the changes are done and tests have passed. Let me know if there's anything else!

@camilamacedo86 camilamacedo86 changed the title 🐛 include group name in crd patches and rbac editor/viewer files 🐛 fix issue to scaffold same Kind for different groups names with multi-group and crd/patch and rbac manifests include group name in crd patches and rbac editor/viewer files Feb 1, 2022
@camilamacedo86 camilamacedo86 changed the title 🐛 fix issue to scaffold same Kind for different groups names with multi-group and crd/patch and rbac manifests include group name in crd patches and rbac editor/viewer files 🐛 fix issue to scaffold same Kind for different groups names with multi-group by include group name in crd patches and rbac editor/viewer files Feb 1, 2022
@camilamacedo86 camilamacedo86 changed the title 🐛 fix issue to scaffold same Kind for different groups names with multi-group by include group name in crd patches and rbac editor/viewer files 🐛 fix issue to scaffold same Kind for different groups with multi-group by using group name in crd/patches and rbac editor/viewer manifests Feb 1, 2022
@camilamacedo86 camilamacedo86 changed the title 🐛 fix issue to scaffold same Kind for different groups with multi-group by using group name in crd/patches and rbac editor/viewer manifests 🐛 fix issue to scaffold same Kind for different groups with multi-group support by using group name in crd/patches and rbac editor/viewer manifests Feb 1, 2022
camilamacedo86
camilamacedo86 approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great contribution 🥇

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, rmb938

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 958ac27 into kubernetes-sigs:master Feb 1, 2022
@rmb938 rmb938 deleted the groupmanifestnames branch February 1, 2022 16:34
@ryantking ryantking mentioned this pull request Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@Adirio Adirio Awaiting requested review from Adirio

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubebuilder with multi-group and same Kind names doesn't generate proper crd/patch and rbac manifests
3 participants
@rmb938 @k8s-ci-robot @camilamacedo86