-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [build] Add support for darwin/arm64 arch #2516
✨ [build] Add support for darwin/arm64 arch #2516
Conversation
More and more users are now using M1 chips for development so publishing kubebuilder-tools in darwin/arm64 arch will enable them to use the project natively on their machines without needing to apply custom ways of solving missing dependencies. Addresses kubernetes-sigs#2505 Signed-off-by: dntosas <ntosas@gmail.com>
affaa7e
to
bb0ab45
Compare
Welcome @dntosas! |
Hi @dntosas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shows great 🥇
We will be able to test/ensure it in the next release.
/approved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, dntosas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
One question. Will this only publish the darwin/arm64 kubebuilder binary or also kubebuilder darwin/arm64 tools (https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases)? |
good question ^ maybe we should also update the branch you mentioned? |
Hi @sbueringer and @dntosas, I could not find a place in https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases where we should change regards this one. Did you find something? |
/test pull-kubebuilder-e2e-k8s-1-16-15 |
/hold |
hey @camilamacedo86 ! the README file maybe 😆 other than that, can't see anything more related ^^ let's wait for @sbueringer also if he got any findings |
I did some research about that a while back and only found: https://github.com/kubernetes-sigs/kubebuilder/pull/1992/files#r573150243 |
makes sense, as Dockerfile seems to take values for |
Hi @dntosas, Let's move forward here. /hold cancel |
Description
More and more users are now using M1 chips for development so publishing
kubebuilder-tools in darwin/arm64 arch will enable them to use the
project natively on their machines without needing to apply custom ways
of solving missing dependencies.
Motivation
Have seen many issues on different projects that utilize
kubebuilder
regarding missingbinaries in
darwin/arm64
arch so I thought to push this. Example Project:operator-sdk
,cluster-api
, etc.Fixes