Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [build] Add support for darwin/arm64 arch #2516

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Feb 20, 2022

Description

More and more users are now using M1 chips for development so publishing
kubebuilder-tools in darwin/arm64 arch will enable them to use the
project natively on their machines without needing to apply custom ways
of solving missing dependencies.

Motivation

Have seen many issues on different projects that utilize kubebuilder regarding missing
binaries in darwin/arm64 arch so I thought to push this. Example Project: operator-sdk, cluster-api, etc.

Fixes

More and more users are now using M1 chips for development so publishing
kubebuilder-tools in darwin/arm64 arch will enable them to use the
project natively on their machines without needing to apply custom ways
of solving missing dependencies.

Addresses kubernetes-sigs#2505

Signed-off-by: dntosas <ntosas@gmail.com>
@dntosas dntosas force-pushed the build/support-for-darwin/arm64-images branch from affaa7e to bb0ab45 Compare February 20, 2022 07:47
@k8s-ci-robot
Copy link
Contributor

Welcome @dntosas!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FillZpp
Copy link

FillZpp commented Feb 21, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2022
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shows great 🥇
We will be able to test/ensure it in the next release.

/approved

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, dntosas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2022
@sbueringer
Copy link
Member

One question. Will this only publish the darwin/arm64 kubebuilder binary or also kubebuilder darwin/arm64 tools (https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases)?
(just asking because I think we want both and I'm not sure how tools is configured)

@dntosas
Copy link
Contributor Author

dntosas commented Feb 22, 2022

One question. Will this only publish the darwin/arm64 kubebuilder binary or also kubebuilder darwin/arm64 tools (https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases)? (just asking because I think we want both and I'm not sure how tools is configured)

good question ^ maybe we should also update the branch you mentioned?

@camilamacedo86
Copy link
Member

Hi @sbueringer and @dntosas,

I could not find a place in https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases where we should change regards this one. Did you find something?

@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-16-15

@camilamacedo86
Copy link
Member

camilamacedo86 commented Feb 22, 2022

/hold
Until we get the answers: #2516 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2022
@dntosas
Copy link
Contributor Author

dntosas commented Feb 22, 2022

hey @camilamacedo86 !

the README file maybe 😆

other than that, can't see anything more related ^^ let's wait for @sbueringer also if he got any findings

@sbueringer
Copy link
Member

Hi @sbueringer and @dntosas,

I could not find a place in https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases where we should change regards this one. Did you find something?

I did some research about that a while back and only found: https://github.com/kubernetes-sigs/kubebuilder/pull/1992/files#r573150243

xref: kubernetes-sigs/cluster-api#6092 (comment)

@dntosas
Copy link
Contributor Author

dntosas commented Feb 22, 2022

makes sense, as Dockerfile seems to take values for GOOS and GOARCH dynamically from the master branch (?) now ^^

@camilamacedo86
Copy link
Member

Hi @dntosas,

Let's move forward here.
I will ping you if it does not work when we try to do the next release

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit cf1575e into kubernetes-sigs:master Feb 22, 2022
@dntosas dntosas deleted the build/support-for-darwin/arm64-images branch February 23, 2022 09:51
@gx14ac gx14ac mentioned this pull request Apr 23, 2022
@ryantking ryantking mentioned this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants