-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 For go/v3, ensure that the plugin can only be used with its go supported version >= 1.17 and < 1.18 #2553
Conversation
Hi @Ankit152. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Ankit152: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The prints with the local tests to show that it works are in; #2546 (comment) So, /lgtm |
/approved |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankit152, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@camilamacedo86 Thank you for merging the pull request 🙂 |
Hey @camilamacedo86 🙂
Here is the new PR. Hope this time it works absolutely fine. Fixes #2530