Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (go/v3) : Upgrade controller-runtime from v0.11.0 to v0.11.2 (k8s api dependencies consequently upgraded from 1.23.0 to 1.23.5) #2584

Merged
merged 1 commit into from
Mar 31, 2022
Merged

✨ (go/v3) : Upgrade controller-runtime from v0.11.0 to v0.11.2 (k8s api dependencies consequently upgraded from 1.23.0 to 1.23.5) #2584

merged 1 commit into from
Mar 31, 2022

Conversation

NikhilSharmaWe
Copy link
Member

@NikhilSharmaWe NikhilSharmaWe commented Mar 31, 2022 •
edited
Loading

Fixes #2502

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2022
@NikhilSharmaWe NikhilSharmaWe changed the title ✨ Updating scaffolds so that dependencies are updated to the required versions ✨ (go/v3) : Upgrade controller-runtime from X to Y (k8s api dependencies consequently upgraded from 1.23.0 to 1.23.5) Mar 31, 2022
@NikhilSharmaWe
(go/v3) : Upgrade controller-runtime from X to Y (k8s api dependencie…
25af98b 
…s consequently upgraded from 1.23.0 to 1.23.5)
@camilamacedo86 camilamacedo86 changed the title ✨ (go/v3) : Upgrade controller-runtime from X to Y (k8s api dependencies consequently upgraded from 1.23.0 to 1.23.5) ✨ (go/v3) : Upgrade controller-runtime from v0.11.0 to v0.11.2 (k8s api dependencies consequently upgraded from 1.23.0 to 1.23.5) Mar 31, 2022
camilamacedo86
camilamacedo86 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, NikhilSharmaWe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@camilamacedo86
Copy link
Member

/override Verify API differences

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • Verify API differences

Only the following contexts were expected:

  • EasyCLA
  • netlify/kubebuilder/deploy-preview
  • pull-kubebuilder-e2e-k8s-1-14-10
  • pull-kubebuilder-e2e-k8s-1-15-12
  • pull-kubebuilder-e2e-k8s-1-16-15
  • pull-kubebuilder-e2e-k8s-1-17-11
  • pull-kubebuilder-e2e-k8s-1-18-8
  • pull-kubebuilder-e2e-k8s-1-19-4
  • pull-kubebuilder-e2e-k8s-1-20-7
  • pull-kubebuilder-e2e-k8s-1-21-2
  • pull-kubebuilder-e2e-k8s-1-22-1
  • pull-kubebuilder-e2e-k8s-1-23-3
  • pull-kubebuilder-test
  • tide

In response to this:

/override Verify API differences

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86
Copy link
Member

/override tide

In this case we want disconsider the api-diff result

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: Overrode contexts on behalf of camilamacedo86: tide

In response to this:

/override tide

In this case we want disconsider the api-diff result

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86 camilamacedo86 merged commit 1fa0449 into kubernetes-sigs:master Mar 31, 2022
@camilamacedo86
Copy link
Member

In this case we need to force and not let the prow does its job
We do have no way to override the API diff. We might want to consider adding this check to infra in the future.

@ryantking ryantking mentioned this pull request Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@Adirio Adirio Awaiting requested review from Adirio

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump k8s 1.23.3 to get bug fixes
3 participants
@NikhilSharmaWe @k8s-ci-robot @camilamacedo86