Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ reverts changes made in 2552 (go/v4-alpha) #2748

Merged
merged 1 commit into from
Jun 18, 2022

Conversation

camilamacedo86
Copy link
Member

Description

Reverts #2552

Motivation

Closes: https://github.com/kubernetes-sigs/kubebuilder/pull/2747/files
Also, let's check this one after the release

…golang base v3 and the new alpha kustomze/v2-alpha"
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2022
@camilamacedo86 camilamacedo86 changed the title Revert "✨(go/v4-alpha): add new golang plugin which uses the default golang base v3 and the new alpha kustomze/v2-alpha" seeding: (go/v4-alpha): add new golang plugin which uses the default golang base v3 and the new alpha kustomze/v2-alpha" Jun 18, 2022
@camilamacedo86 camilamacedo86 changed the title seeding: (go/v4-alpha): add new golang plugin which uses the default golang base v3 and the new alpha kustomze/v2-alpha" :seeding: (go/v4-alpha): add new golang plugin which uses the default golang base v3 and the new alpha kustomze/v2-alpha" Jun 18, 2022
@camilamacedo86 camilamacedo86 changed the title :seeding: (go/v4-alpha): add new golang plugin which uses the default golang base v3 and the new alpha kustomze/v2-alpha" 🌱 : (go/v4-alpha): add new golang plugin which uses the default golang base v3 and the new alpha kustomze/v2-alpha" Jun 18, 2022
@camilamacedo86 camilamacedo86 changed the title 🌱 : (go/v4-alpha): add new golang plugin which uses the default golang base v3 and the new alpha kustomze/v2-alpha" 🌱 : Reverts #2552 (go/v4-alpha): Jun 18, 2022
@camilamacedo86 camilamacedo86 changed the title 🌱 : Reverts #2552 (go/v4-alpha): 🌱 reverts #2552 (go/v4-alpha): Jun 18, 2022
@camilamacedo86 camilamacedo86 changed the title 🌱 reverts #2552 (go/v4-alpha): 🌱 reverts changes made in 2552 (go/v4-alpha): Jun 18, 2022
@camilamacedo86 camilamacedo86 changed the title 🌱 reverts changes made in 2552 (go/v4-alpha): 🌱 reverts changes made in 2552 (go/v4-alpha) Jun 18, 2022
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-19-16

@camilamacedo86
Copy link
Member Author

Moving forward to not block the other contributions.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2022
@camilamacedo86 camilamacedo86 changed the title 🌱 reverts changes made in 2552 (go/v4-alpha) ⚠️ reverts changes made in 2552 (go/v4-alpha) Jun 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 862e422 into master Jun 18, 2022
@camilamacedo86 camilamacedo86 deleted the revert-2552-newPlugin branch April 16, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants