-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (phase 2 plugins): enable external plugins to specify metadata and examples #2780
✨ (phase 2 plugins): enable external plugins to specify metadata and examples #2780
Conversation
Hi @everettraven. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
d60aea0
to
fc97428
Compare
The APIDiff failure is expected as there was a change made to the external plugin API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🥇
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@camilamacedo86 The APIDiff failure is expected since the external plugin API was changed for this. Would you be able to override this check so it can merge? Thanks! |
Description of the change
Update the
external
plugin implementation to allow external plugins to specify metadata and examples for their plugin:UpdateMetadata
function to theinit
,create api
,create webhook
, andedit
subcommandsAdd a new helper function called
makePluginRequest
for making requests to external plugins. This makes the code for making a request to external plugins easier to reuse and prevents code duplication.Motivation for the change
This change allows external plugins to specify the metadata and examples that are provided to a Kubebuilder CLI user when they request the help text for a plugin. This gives Kubebuilder CLI users the same native plugin feeling for external plugins.
For more information see issue #2690
Additional Context
resolves #2690