Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (API) remove KustomizeVersion const from golang plugin ( the version is defined in the kustomize plugins which is responsable for ) #2787

Merged
merged 1 commit into from
Jul 4, 2022
Merged

🐛 (API) remove KustomizeVersion const from golang plugin ( the version is defined in the kustomize plugins which is responsable for ) #2787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions pkg/plugins/golang/v3/scaffolds/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,6 @@ const (
ControllerRuntimeVersion = "v0.12.1"
// ControllerToolsVersion is the kubernetes-sigs/controller-tools version to be used in the project
ControllerToolsVersion = "v0.9.0"
// KustomizeVersion is the kubernetes-sigs/kustomize version to be used in the project
// @Deprecated. This information ought to come from kustomize plugin
// Note that by updating the following value nothing will change for the go/3 plugin
// it is no longer used and it was not removed only because it would be a breaking
// change for the API. (api-diff check)
//
// NOTE: If you want to update the kustomize version used by this plugin
// then you need to update it in pkg/plugins/common/kustomize/v1/plugin.go
// Todo: we should remove it for the next go/v4 plugin
KustomizeVersion = "v3.8.7"

imageName = "controller:latest"
)
Expand Down