✨deploy-image/v1-alpha: add finalizers for the Custom Resource created

[NikhilSharmaWe]

Description

Add finalizers for the Custom Resource created for deleting the deployment under before deleting the CR.

Motivation

Fixes part of #2765

[camilamacedo86]

/hold

Until the fixes be made

[camilamacedo86]

Suggested change

	events, err := kbc.Kubectl.Get(true, "events", "--field-selector", "type", "Warning",
	events, err := kbc.Kubectl.Get(true, "events", "--field-selector=type=Warning",

TO fix the command:

[camilamacedo86]

Suggested change

"github.com/go-logr/logr"

@NikhilSharmaWe we need to use the log from the controller-runtime which is provided in the reconcile (see the log var) and not this one.

[NikhilSharmaWe]

Yes, I was using that log only but I was using this for specifying the parameters of the finalize function but since now that parameter is not needed(due some changes in the finalize function), I am removing it.

[camilamacedo86]

@NikhilSharmaWe,

The new occurs because the recorder is empty and needs to be passed when we create the controller and pass it in the manager ( main.go ):

if err = (&controllers.FoorxobReconciler{
   Client:   mgr.GetClient(),
   Scheme:   mgr.GetScheme(),
   Recorder: mgr.GetEventRecorderFor("mykind-controller"),
}).SetupWithManager(mgr); err != nil {
   setupLog.Error(err, "unable to create controller", "controller", "Foorxob")
   os.Exit(1)
}
//+kubebuilder:scaffold:builder

Also, in the controller, it needs to be changed to be Upper case: Recorder record.EventRecorder
Then, when we call the event use Eventf instead of Event since we want to format the message

See that this PR does not have the e2e check as well. It is missing can you come back that?

[camilamacedo86]

@NikhilSharmaWe,

Instead of use replace the best approach here would we create a MainUpdater like:

https://github.com/NikhilSharmaWe/kubebuilder/blob/f604a6cb2c4a3ba5425471ace96125630c9a50f3/pkg/plugins/golang/v3/scaffolds/api.go#L106-L110

Then, in this updater we will have another template for the controller in the main: https://github.com/NikhilSharmaWe/kubebuilder/blob/f604a6cb2c4a3ba5425471ace96125630c9a50f3/pkg/plugins/golang/v3/scaffolds/internal/templates/main.go#L100-L106

Could you please add a TODO on top of the method at least such as

// TODO: replace this implementation by creating its own MainUpdater which will have its own controller template which set the recorder.

Also, could you please change the target so we ensure that you ONLY set the event.Recorder on the Controller code of the specific api instead of adding the code in all of them? If we have a project with an API that uses the plugin and another API that does not use the plugin only the API that uses the plugin should have this addition.

[k8s-ci-robot]

@NikhilSharmaWe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubebuilder-e2e-k8s-1-19-16	2bc1a66	link	false	/test pull-kubebuilder-e2e-k8s-1-19-16

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[camilamacedo86]

@NikhilSharmaWe,

The fix: https://github.com/kubernetes-sigs/kubebuilder/pull/2793/files#r915313169 is not a blocker for the PR. So, let's move forward and improve it in a follow up

/lgtm
/approved

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, NikhilSharmaWe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

/test pull-kubebuilder-e2e-k8s-1-19-16

[camilamacedo86]

/hold cancel