-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Add cloudbuild #3246
[infra] Add cloudbuild #3246
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- "KUBE_RBAC_PROXY_VERSION=${_KUBE_RBAC_PROXY_VERSION}" | ||
entrypoint: "/usr/bin/env" | ||
args: ["bash", "-c", "./build/build.sh"] | ||
images: ["gcr.io/kubebuilder/kube-rbac-proxy:${_KUBE_RBAC_PROXY_VERSION}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The registry in this case should not be the same.
Also, do we should work with cludbuild to setup the new infra OR just call the shell script in their job?
By looking the example with run, should not we call only the shell?
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
We moved forward by duplicating the directories and have one for each scenario so that we do not broke the current state. However, we still need to check if that is working there and what would be the next steps. So, I am closing this one but if you see that we still needing to do address anything else and etc, please feel free to re-open or open a follow up. |
No description provided.