Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Revert ":bug: Align CRD version validation with apiextensions" #3787

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

camilamacedo86
Copy link
Member

Reverts #3742

Closes: #3784

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2024
@camilamacedo86 camilamacedo86 changed the title Revert ":bug: Align CRD version validation with apiextensions" 🐛 Revert ":bug: Align CRD version validation with apiextensions" Feb 16, 2024
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Feb 16, 2024

We need revert this one.

Using IsDNS1035Label to validate a Kubernetes CRD Kind name is not accurate because this validation is intended for DNS labels, which have stricter requirements, such as needing to start with a lowercase letter and consisting only of lowercase alphanumeric characters and '-', which does not align with the conventions for Kind names in Kubernetes. Kind names typically follow CamelCase and can start with uppercase letters, which would not be permitted by IsDNS1035Label. Therefore, it would not allow names like "DNS" for a Kind due to these constraints.

Copy link
Member Author

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Regression

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: you cannot LGTM your own PR.

In response to this:

/lgtm

Regression

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 488bb98 into master Feb 16, 2024
32 of 33 checks passed
@camilamacedo86 camilamacedo86 deleted the revert-3742-gh-3739 branch April 6, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create an API of Kind with name DNS but creating an API of Kind with name ENS works fine
2 participants