Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱: Add prefix to bot PR title to respect community rule #3810

Merged
merged 1 commit into from
Mar 29, 2024
Merged

🌱: Add prefix to bot PR title to respect community rule #3810

merged 1 commit into from
Mar 29, 2024

Conversation

Kavinjsir
Copy link
Contributor

Description

Add a condition to skip PR Verifier if the PR is created by dependabot

Motivation

Current PRs created by dependabot fail the CI/CD workflows as the title of the PR does not match the community's criteria.
It seems dependabot does NOT provide an entry to configure the title, so I am thinking if we can just skip the PR verifier in such scenarios.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
@Kavinjsir Kavinjsir changed the title chore: skip verifying bot pr 🌱: skip verifying bot pr Mar 6, 2024
mateusoliveira43
mateusoliveira43 suggested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@mateusoliveira43 mateusoliveira43 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not be this achieved by using this option https://github.com/migtools/oadp-non-admin/blob/master/.github/dependabot.yml#L10 ? in kubebuilder case, setting it to 🌱

@Kavinjsir Kavinjsir force-pushed the chore/skip-verifying-bot-pr branch from ac61f10 to f74d80c Compare March 6, 2024 20:48
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
@Kavinjsir
Copy link
Contributor Author

Can not be this achieved by using this option https://github.com/migtools/oadp-non-admin/blob/master/.github/dependabot.yml#L10 ? in kubebuilder case, setting it to 🌱

Great suggestion! Just applied that.

mateusoliveira43
mateusoliveira43 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@mateusoliveira43 mateusoliveira43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would just change PR title
LGTM

@Kavinjsir Kavinjsir changed the title 🌱: skip verifying bot pr 🌱: Add prefix to bot PR title to respect community rule Mar 9, 2024
camilamacedo86
camilamacedo86 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is great 🥇

Thank you a lot

/approved
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024
@camilamacedo86
Copy link
Member

@dependabot rebase

@k8s-ci-robot k8s-ci-robot merged commit 7f14b2f into kubernetes-sigs:master Mar 29, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusoliveira43 mateusoliveira43 mateusoliveira43 approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kavinjsir @k8s-ci-robot @camilamacedo86 @mateusoliveira43