-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: Remove empty line at beginning of generated files #3815
🐛 fix: Remove empty line at beginning of generated files #3815
Conversation
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Hi @mateusoliveira43. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, lukas016, mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The legacy test was removed so, in order of not need to ask extra effort from the author I am forcing the merge which seems very safe in this case scenario. |
1bd70b3
into
kubernetes-sigs:master
Why the changes were made
Noticed that after generating project with kubebuilder, some files had an empty line in their first line. This PR fixes this.
How the changes were made
Tried to find all files templates that started with an empty line in
pkg/plugins/golang/v4/scaffolds/internal/templates
folder. Removed it from them and ranmake generate
.How to test the changes made
Confirm the changes do not break any use case.