🐛 cleanup/enhancement: keep all variables used defined on top of`main.go` #4036

fengshunli · 2024-07-21T10:58:52Z

This update streamlines the code and enhances maintainability by centralizing variable definitions.

k8s-ci-robot · 2024-07-21T10:59:01Z

Hi @fengshunli. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

camilamacedo86

@fengshunli

Thank you for your contribution.
After do change you must run make generate so that all samples and docs are updated accordingly. So, could you please do that and ensure that your PR will result with just 1 commit so that we can get this one merged?

fengshunli · 2024-07-21T11:12:20Z

@camilamacedo86 done

camilamacedo86

/ok-to-test
/approved
/lgtm

camilamacedo86

Just a nit sorry.
Could you please address this one : https://github.com/kubernetes-sigs/kubebuilder/pull/4036/files#r1686316224 for we get it merged

Also, see that I updated the title since we use it to generate the release notes.

testdata/project-v4-multigroup-with-deploy-image/cmd/main.go

fengshunli · 2024-07-22T12:16:27Z

Just a nit sorry. Could you please address this one : https://github.com/kubernetes-sigs/kubebuilder/pull/4036/files#r1686316224 for we get it merged

Also, see that I updated the title since we use it to generate the release notes.

done

camilamacedo86 · 2024-07-22T13:37:17Z

pkg/plugins/golang/v4/scaffolds/internal/templates/main.go

+	var (
+		metricsAddr          string
+		enableLeaderElection bool
+		probeAddr            string
+		secureMetrics        bool
+		enableHTTP2          bool
+		tlsOpts              []func(*tls.Config)
+	)


Suggested change

var (

metricsAddr string

enableLeaderElection bool

probeAddr string

secureMetrics bool

enableHTTP2 bool

tlsOpts []func(*tls.Config)

)

var metricsAddr string

var enableLeaderElection bool

var probeAddr string

var secureMetrics bool

var enableHTTP2 bool

var tlsOpts []func(*tls.Config)

That ^ @fengshunli and then just run make generate

I don't understand why the var code block is not used here to define it. Isn't the code block definition more standardized? @camilamacedo86

What value do add with this change?
It will only make harder for people upgrade/update their project with the latest changes
It has no need to change it in the scaffold. Lets try to only do in each PR what is required to achieve the goal of the PR itself.

camilamacedo86 · 2024-07-22T16:22:24Z

docs/book/src/multiversion-tutorial/testdata/project/cmd/main.go

@@ -64,8 +64,6 @@ func init() {
 /*
 */
 func main() {
-	/*
-	 */


Can you please revert it ?
It is used in the docs to render the code and has no relation with the purpose of this PR

…management Signed-off-by: fsl <1171313930@qq.com>

camilamacedo86

/lgtm
/ok-to-test

k8s-ci-robot · 2024-07-23T05:46:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, fengshunli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2024

k8s-ci-robot requested review from camilamacedo86 and everettraven July 21, 2024 10:59

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2024

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 21, 2024

fengshunli force-pushed the var branch from caf0351 to ceefa5b Compare July 21, 2024 11:00

camilamacedo86 reviewed Jul 21, 2024

View reviewed changes

fengshunli force-pushed the var branch from ceefa5b to 958fcab Compare July 21, 2024 11:11

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2024

fengshunli force-pushed the var branch 2 times, most recently from 5c15612 to b493b93 Compare July 21, 2024 12:40

camilamacedo86 changed the title ~~Unified variable management~~ ✨ Improved variable definitions in main.go to achieve unified variable management Jul 22, 2024

camilamacedo86 approved these changes Jul 22, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2024

k8s-ci-robot assigned camilamacedo86 Jul 22, 2024

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2024

camilamacedo86 requested changes Jul 22, 2024

View reviewed changes

k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024

camilamacedo86 removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2024

camilamacedo86 reviewed Jul 22, 2024

View reviewed changes

testdata/project-v4-multigroup-with-deploy-image/cmd/main.go Outdated Show resolved Hide resolved

fengshunli force-pushed the var branch from b493b93 to 78a0ff2 Compare July 22, 2024 12:14

camilamacedo86 reviewed Jul 22, 2024

View reviewed changes

camilamacedo86 changed the title ~~✨ Improved variable definitions in main.go to achieve unified variable management~~ ✨ enhance in themain.go to achieve unified variable management Jul 22, 2024

camilamacedo86 changed the title ~~✨ enhance in themain.go to achieve unified variable management~~ ✨ cleanup/enhance: keep all variables used defined on top ofmain.go Jul 22, 2024

camilamacedo86 changed the title ~~✨ cleanup/enhance: keep all variables used defined on top ofmain.go~~ ✨ cleanup/enhancement: keep all variables used defined on top ofmain.go Jul 22, 2024

camilamacedo86 changed the title ~~✨ cleanup/enhancement: keep all variables used defined on top ofmain.go~~ 🐛 cleanup/enhancement: keep all variables used defined on top ofmain.go Jul 22, 2024

fengshunli force-pushed the var branch from 78a0ff2 to 4a00dc7 Compare July 22, 2024 14:16

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2024

camilamacedo86 reviewed Jul 22, 2024

View reviewed changes

Improved variable definitions in main.go to achieve unified variable …

4d86fcd

…management Signed-off-by: fsl <1171313930@qq.com>

fengshunli force-pushed the var branch from 4a00dc7 to 4d86fcd Compare July 22, 2024 22:35

camilamacedo86 approved these changes Jul 23, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024

k8s-ci-robot merged commit 73848f8 into kubernetes-sigs:master Jul 23, 2024
17 checks passed

fengshunli mentioned this pull request Jul 23, 2024

REQUEST: New membership for fengshunli kubernetes/org#5075

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 cleanup/enhancement: keep all variables used defined on top of`main.go` #4036

🐛 cleanup/enhancement: keep all variables used defined on top of`main.go` #4036

fengshunli commented Jul 21, 2024 •

edited by camilamacedo86

Loading

k8s-ci-robot commented Jul 21, 2024

camilamacedo86 left a comment

fengshunli commented Jul 21, 2024

camilamacedo86 left a comment

camilamacedo86 left a comment •

edited

Loading

fengshunli commented Jul 22, 2024

camilamacedo86 Jul 22, 2024

fengshunli Jul 22, 2024

camilamacedo86 Jul 22, 2024

camilamacedo86 Jul 22, 2024

fengshunli Jul 22, 2024

camilamacedo86 left a comment

k8s-ci-robot commented Jul 23, 2024

🐛 cleanup/enhancement: keep all variables used defined on top ofmain.go #4036

🐛 cleanup/enhancement: keep all variables used defined on top ofmain.go #4036

Conversation

fengshunli commented Jul 21, 2024 • edited by camilamacedo86 Loading

k8s-ci-robot commented Jul 21, 2024

camilamacedo86 left a comment

Choose a reason for hiding this comment

fengshunli commented Jul 21, 2024

camilamacedo86 left a comment

Choose a reason for hiding this comment

camilamacedo86 left a comment • edited Loading

Choose a reason for hiding this comment

fengshunli commented Jul 22, 2024

camilamacedo86 Jul 22, 2024

Choose a reason for hiding this comment

fengshunli Jul 22, 2024

Choose a reason for hiding this comment

camilamacedo86 Jul 22, 2024

Choose a reason for hiding this comment

camilamacedo86 Jul 22, 2024

Choose a reason for hiding this comment

fengshunli Jul 22, 2024

Choose a reason for hiding this comment

camilamacedo86 left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 23, 2024

🐛 cleanup/enhancement: keep all variables used defined on top of`main.go` #4036

🐛 cleanup/enhancement: keep all variables used defined on top of`main.go` #4036

fengshunli commented Jul 21, 2024 •

edited by camilamacedo86

Loading

camilamacedo86 left a comment •

edited

Loading