Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (deployimage/v1apha1): fix linter issues #4112

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Aug 29, 2024

This PR fixes the following issues:

$ make lint
testdata/project-v4-with-deploy-image/bin/golangci-lint run
internal/controller/busybox_controller.go:338:6: comment-spacings: no space between comment delimiter and comment text (revive)
					//Affinity: &corev1.Affinity{
					^
internal/controller/busybox_controller.go:359:6: comment-spacings: no space between comment delimiter and comment text (revive)
					//},
					^
internal/controller/memcached_controller.go:338:6: comment-spacings: no space between comment delimiter and comment text (revive)
					//Affinity: &corev1.Affinity{
					^
internal/controller/busybox_controller.go:400:23: `labelsForBusybox` - `name` is unused (unparam)
func labelsForBusybox(name string) map[string]string {
                      ^
internal/controller/memcached_controller.go:406:25: `labelsForMemcached` - `name` is unused (unparam)
func labelsForMemcached(name string) map[string]string {
                        ^
make: *** [lint] Error 1

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2024
@camilamacedo86
Copy link
Member Author

I am moving forward because it is a nit/fix
We have big fishes to fry and we need help with a lot of PRs reviews.
So, I will not make nobody waste time on this one.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit ac6f467 into kubernetes-sigs:master Aug 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants