✨ (go/v4) Add Metrics Validation and Helper Functions to E2E Tests #4124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
test-e2e-impro
branch
7 times, most recently
from
db3877e to
331bac7
Compare
k8s-ci-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
test-e2e-impro
branch
from
331bac7 to
82baf26
Compare
k8s-ci-robot
removed
the
needs-rebase
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
test-e2e-impro
branch
2 times, most recently
from
8f6e1f0 to
69c1d84
Compare
k8s-ci-robot
added
the
needs-rebase
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
test-e2e-impro
branch
from
69c1d84 to
66c6b1a
Compare
k8s-ci-robot
removed
the
needs-rebase
camilamacedo86
force-pushed
the
test-e2e-impro
branch
from
66c6b1a to
94633cc
Compare
k8s-ci-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
test-e2e-impro
branch
from
94633cc to
1a4cd8e
Compare
k8s-ci-robot
removed
the
needs-rebase
camilamacedo86
force-pushed
the
test-e2e-impro
branch
2 times, most recently
from
a9b1d9c to
d714031
Compare
camilamacedo86
changed the title
|
With this one I think we can address all. |
|
/hold false It seems great to fly 🚀 |
camilamacedo86
removed
the
do-not-merge/hold
mogsie
reviewed
Sep 3, 2024
pkg/plugins/golang/v4/scaffolds/internal/templates/test/e2e/suite.go
Outdated
Show resolved
Hide resolved
| ExpectWithOffset(2, token).NotTo(BeEmpty()) | ||
|
|
||
| By("waiting for the metrics endpoint to be ready") | ||
| verifyMetricsEndpointReady := func() error { |
There was a problem hiding this comment.
Eventually funcs can take a Gomega parameter, which you can then use to verify, instead of returning an error.
verifyMetricsEndpointReady := func(g Gomega) {
cmd := exec.Command("kubectl", "get", "endpoints", metricsServiceName, "-n", namespace)
g.Expect(utils.Run(cmd)).To(ContainSubstring("8443"))
})
Eventually(verifyMetricsEndpointReady).WithTimeout(...).Should(Succeed())
you shouldn't need the WithOffset(2), and the whole test is somewhat more condensed, since it's not mixing the go error handling with Expectations.
g.Expect() in the snippet above both should check the error be nil and the contents of the output string (not 100% sure about the type conversion from []byte to string, though).
Provide further improvements for e2e tests test to help users be aware of how to tests using the metrics endpoint and validate if the metrics are properly expose.
camilamacedo86
force-pushed
the
test-e2e-impro
branch
2 times, most recently
from
5d772aa to
f867ac0
Compare
|
/lgtm (not that I think I have a say in the matter 😄) |
|
@mogsie: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide further improvements for e2e tests test to help users be aware of how to tests using the metrics endpoint and validate if the metrics are properly expose. Furthermore, shows how to use it to validate the reconciliation.
Partially closes: #4120