✨ Add support to scaffold webhooks for External Types #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
camilamacedo86
force-pushed
the
webhooks-core-types
branch
2 times, most recently
from
26bf68a to
736b8a0
Compare
This was referenced Oct 2, 2024
camilamacedo86
force-pushed
the
webhooks-core-types
branch
from
736b8a0 to
2c8a24a
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
webhooks-core-types
branch
from
1744bec to
1faaf9c
Compare
k8s-ci-robot
added
the
needs-rebase
This update introduces support for scaffolding webhooks for external types, which are APIs/CRDs defined in other projects
camilamacedo86
force-pushed
the
webhooks-core-types
branch
from
1faaf9c to
1be2b8b
Compare
k8s-ci-robot
removed
the
needs-rebase
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
varshaprasad96
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
This feature has been waiting for long to get into KB! Thanks @camilamacedo86 for taking care of it!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
camilamacedo86
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the creation of webhooks for external types.
For further discussion, please refer to this issue: #4201.
Motivation: #4176