✨ Upgrade golangci-lint from v1.59 to v1.61 and resolve new lint issues #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
upgrade-lint-v1-61
branch
2 times, most recently
from
be2e664 to
92d2ae8
Compare
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
upgrade-lint-v1-61
branch
from
92d2ae8 to
e8d5367
Compare
|
I will not make nobody waste time on this review |
camilamacedo86
added
the
lgtm
- Upgraded golangci-lint from v1.59 to v1.61. - Fixed issues flagged by new lint rules in v1.61: - Resolved `comment-spacings` errors in api.go by adding spaces after `//` delimiters. - Addressed `govet` error by formatting non-constant strings in `fmt.Errorf`. - Updated `staticcheck` issues in resource.go by replacing `fmt.Errorf` with `errors.New` for static error messages. - Deprecated the `exportloopref` linter, replaced by `copyloopvar` for Go 1.22+.
camilamacedo86
force-pushed
the
upgrade-lint-v1-61
branch
from
e8d5367 to
ca02865
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade golangci-lint from v1.59 to v1.61 and resolve new lint issues
comment-spacingserrors in api.go by adding spaces after//delimiters.goveterror by formatting non-constant strings infmt.Errorf.staticcheckissues in resource.go by replacingfmt.Errorfwitherrors.Newfor static error messages.exportloopreflinter, replaced bycopyloopvarfor Go 1.22+.