-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 clarify usage of alpha generate command as internal-only #4247
🐛 clarify usage of alpha generate command as internal-only #4247
Conversation
Added comments to `NewScaffoldCommand` to clarify that the `kubebuilder alpha generate` command is designed for Kubebuilder’s internal use only. The updated go documentation explains that importing this command into other projects is not supported, as it relies on Kubebuilder-specific configurations, key mappings, and plugins, which may not be applicable to other setups. Projects that use Kubebuilder as a library and require similar functionality should implement a custom solution for compatibility with their specific configurations and plugins.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @acornett21, JFY. |
@camilamacedo86 shouldn't this also be mentioned in the kubebuilder's official docs? Devs rely on the official website 1st before, exploring the repo. |
Hi @TAM360
It is only relevant for those who maintain projects which uses Kubebuilder as Lib. Example maintainers of Operator-SDK So, I have no idea about where more add the info. If you have any suggestion please feel free to let us know. |
@camilamacedo86 Go docs would be enough IMO. |
@camilamacedo86 Is there some unforeseen issue caused by this that I'm missing? |
Hi @acornett21 It seems that we are importing the alpha generated in SDK, see: https://github.com/operator-framework/operator-sdk/blob/819984d4c1a51c8ff2ef6c23944554148ace0752/website/content/en/docs/cli/operator-sdk_alpha_generate.md?plain=1#L4 If we at some point bump KB there we might want to give a look on that and ensure that we are not using this command there. It cannot work with SDK projects. |
I am moving forward with this one since here we are only add a comment to clarify the intent purpose of the command. |
It looks like maybe that this point this cmd should just be removed. Thanks for the callout. |
Added comments to
NewScaffoldCommand
to clarify that thekubebuilder alpha generate
command is designed for Kubebuilder’s internal use only.The updated go documentation explains that importing this command into other projects is not supported, as it relies on Kubebuilder-specific configurations, key mappings, and plugins, which may not be applicable to other setups.
Projects that use Kubebuilder as a library and require similar functionality should implement a custom solution for compatibility with their specific configurations and plugins.
Closes: #4200