🌱 Add bundle installer for sample projects in docs #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
add-installer-fix-doc-samples
branch
from
b25d8ae to
fe444ab
Compare
|
This change primarily benefits maintainers. It doesn’t introduce visible changes or impact end-users but is a minor enhancement to streamline our internal review process. Given our current workload and the number of pending PRs, I’ll move forward without additional review to save time. This update allows us to focus on other critical requirements while making reviews more efficient. |
Introduces a bundle installer for sample projects, with config/default/kustomization.yaml settings uncommented to ensure complete bundle generation. This enhances review visibility by showing the final state of patches and Kustomize configurations directly in the generated bundle. Motivation: Makes reviews more efficient by displaying final configurations directly in the bundle, with only relevant settings uncommented in config/default/kustomization.yaml for each sample.
camilamacedo86
force-pushed
the
add-installer-fix-doc-samples
branch
from
fe444ab to
a31eb7c
Compare
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a bundle installer for sample projects, with config/default/kustomization.yaml settings uncommented to ensure complete bundle generation. This enhances review visibility by showing the final state of patches and Kustomize configurations directly in the generated bundle.
Motivation: Makes reviews more efficient by displaying final configurations directly in the bundle, with only relevant settings uncommented in config/default/kustomization.yaml for each sample.