-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added client-go auth plugins #91
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @pyrsson! |
LGTM but i wonder if we can have a test for that 🤔 |
I could give it a go, but I'm not entirely sure what the tests should cover. My understanding is that there is fairly little value in writing tests for library functionality, but I could be wrong. Do you have a suggestion for what to test in |
/lgtm From a glance it looks like adding a good test for this requires infra we dont have to stand up a fake cluster requiring the plugin. Since this is a single line addition simply to link the library I think it is ok to add |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, pyrsson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds support for clusters using any of the client-go auth plugins like oidc based on these docs: client-go examples
Fixes validation of CRDs when connected to a cluster with oidc for example:
Which issue(s) this PR fixes:
Didn't open an issue, hope that's ok.
Special notes for your reviewer:
First ever contribution, please let me know if there's something I missed or need to change.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: