Skip to content

Commit

Permalink
ansible-lint: E403 Package installs should not use latest
Browse files Browse the repository at this point in the history
  • Loading branch information
Miouge1 committed Apr 11, 2019
1 parent 3af90f8 commit e8f1825
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 20 deletions.
1 change: 0 additions & 1 deletion .ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ skip_list:
- '303'
- '305'
- '306'
- '403'
- '404'
- '502'
- '503'
Expand Down
20 changes: 2 additions & 18 deletions contrib/kvm-setup/roles/kvm-setup/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
---

- name: Upgrade all packages to the latest version (yum)
yum:
name: '*'
state: latest
when: ansible_os_family == "RedHat"

- name: Install required packages
yum:
name: "{{ item }}"
state: latest
state: present
with_items:
- bind-utils
- ntp
Expand All @@ -21,23 +15,13 @@
update_cache: yes
cache_valid_time: 3600
name: "{{ item }}"
state: latest
state: present
install_recommends: no
with_items:
- dnsutils
- ntp
when: ansible_os_family == "Debian"

- name: Upgrade all packages to the latest version (apt)
shell: apt-get -o \
Dpkg::Options::=--force-confdef -o \
Dpkg::Options::=--force-confold -q -y \
dist-upgrade
environment:
DEBIAN_FRONTEND: noninteractive
when: ansible_os_family == "Debian"


# Create deployment user if required
- include: user.yml
when: k8s_deployment_user is defined
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- name: install growpart
package:
name: cloud-utils-growpart
state: latest
state: present

- name: check if growpart needs to be run
command: growpart -N /dev/sda 1
Expand Down

0 comments on commit e8f1825

Please sign in to comment.