iptables switch for docker #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
holser
commented
Feb 21, 2017
•
holser
commented
k8s-ci-robot
added
the
cncf-cla: yes
mattymo
reviewed
Feb 21, 2017
inventory/group_vars/all.yml
Outdated
| @@ -191,11 +191,13 @@ dns_server: "{{ kube_service_addresses|ipaddr('net')|ipaddr(2)|ipaddr('address') | |||
| # Path used to store Docker data | |||
| docker_daemon_graph: "/var/lib/docker" | |||
|
|
|||
| docker_iptables: false | |||
There was a problem hiding this comment.
That's not how all.yml file works. We don't stuff every possible option here. We only put the ones users are likely to want to change. Please move it to roles/docker/defaults/main.yml and default to false. It actually breaks deployments when set to true, so I doubt we want to invite users to re-enable it.
mattymo
suggested changes
Feb 21, 2017
mattymo
approved these changes
Feb 21, 2017
|
ci check this |
added 2 commits
February 21, 2017 19:10
Docker 1.13 changes the behaviour of iptables defaults from allow to drop. This patch disables docker's iptables management as it was in Docker 1.12 [1] [1] moby/moby#28257 Signed-off-by: Sergii Golovatiuk <sgolovatiuk@mirantis.com>
- Remove variable dup for Ubuntu - Update Docker to 1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.