-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added host_vars to gitignore #1100
Conversation
Since inventory ships with kargo, the ability to change functionality without having a dirty git index is nice. An example, we wish to change is the version of docker deployed to our CentOS systems. Due to an issue with tiller and docker 1.13, we wish to deploy docker 1.12. Since this change does not belong in Kargo, we wish to locally override the docker version, until the issue is sorted.
.gitignore
Outdated
@@ -2,6 +2,7 @@ | |||
*.retry | |||
inventory/vagrant_ansible_inventory | |||
inventory/group_vars/fake_hosts.yml | |||
inventory/host_vars/k8s-0*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just write it as inventory/host_vars. There's no need to exclude just a certain host pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I know. I was simply trying to explicitly target the vagrant inventory hosts, in the event we choose to add host inventory down the road.
@retr0h Can you link to the bug with Docker 1.13 and tiller? I'm just curious |
I haven't gone bug searching yet. My CentOS/7 box does not work with tiller (1.2.3) and docker (1.13.0). However, Docker 1.12.6 works, and Docker 1.13.1 (appears to work). Error is:
|
I think it's helm/helm#1838 but sounds like 1.13.1 fixes the issue |
I thought of closing this PR, altho the functionality does seems useful for local overrides. |
@mattymo updated per your review. |
Yes, Docker 1.13.1 fixes the issue.
|
Since inventory ships with kargo, the ability to change functionality
without having a dirty git index is nice. An example, we wish to change
is the version of docker deployed to our CentOS systems. Due to an issue
with tiller and docker 1.13, we wish to deploy docker 1.12. Since this
change does not belong in Kargo, we wish to locally override the docker
version, until the issue is sorted.