Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added host_vars to gitignore #1100

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Added host_vars to gitignore #1100

merged 2 commits into from
Mar 2, 2017

Conversation

retr0h
Copy link
Contributor

@retr0h retr0h commented Mar 1, 2017

Since inventory ships with kargo, the ability to change functionality
without having a dirty git index is nice. An example, we wish to change
is the version of docker deployed to our CentOS systems. Due to an issue
with tiller and docker 1.13, we wish to deploy docker 1.12. Since this
change does not belong in Kargo, we wish to locally override the docker
version, until the issue is sorted.

Since inventory ships with kargo, the ability to change functionality
without having a dirty git index is nice.  An example, we wish to change
is the version of docker deployed to our CentOS systems.  Due to an issue
with tiller and docker 1.13, we wish to deploy docker 1.12.  Since this
change does not belong in Kargo, we wish to locally override the docker
version, until the issue is sorted.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2017
.gitignore Outdated
@@ -2,6 +2,7 @@
*.retry
inventory/vagrant_ansible_inventory
inventory/group_vars/fake_hosts.yml
inventory/host_vars/k8s-0*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just write it as inventory/host_vars. There's no need to exclude just a certain host pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know. I was simply trying to explicitly target the vagrant inventory hosts, in the event we choose to add host inventory down the road.

@mattymo
Copy link
Contributor

mattymo commented Mar 1, 2017

@retr0h Can you link to the bug with Docker 1.13 and tiller? I'm just curious

@retr0h
Copy link
Contributor Author

retr0h commented Mar 1, 2017

@retr0h Can you link to the bug with Docker 1.13 and tiller? I'm just curious

I haven't gone bug searching yet. My CentOS/7 box does not work with tiller (1.2.3) and docker (1.13.0). However, Docker 1.12.6 works, and Docker 1.13.1 (appears to work).

Error is:

{kubelet k8s-01}                        Warning         FailedSync      Error syncing pod, skipping: failed to "SetupNetwork" for "tiller-deploy-3299276078-wrkrq_kube-system" with SetupNetworkError: "Failed to setup network for pod \"tiller-deploy-3299276078-wrkrq_kube-system(c9d8fd31-fdd6-11e6-af1c-525400225b53)\" using network plugins \"cni\": failed to move veth to host netns: file exists; Skipping pod”"

@bradbeam
Copy link
Contributor

bradbeam commented Mar 1, 2017

I think it's helm/helm#1838 but sounds like 1.13.1 fixes the issue

@retr0h
Copy link
Contributor Author

retr0h commented Mar 1, 2017

I think it's helm/helm#1838 but sounds like 1.13.1 fixes the issue

I thought of closing this PR, altho the functionality does seems useful for local overrides.

@retr0h
Copy link
Contributor Author

retr0h commented Mar 1, 2017

@mattymo updated per your review.

@retr0h
Copy link
Contributor Author

retr0h commented Mar 1, 2017

I think it's helm/helm#1838 but sounds like 1.13.1 fixes the issue

Yes, Docker 1.13.1 fixes the issue.

[vagrant@k8s-01 ~]$ helm init --tiller-image docker.io/port/tiller:v2.1.3
Creating /home/vagrant/.helm
Creating /home/vagrant/.helm/repository
Creating /home/vagrant/.helm/repository/cache
Creating /home/vagrant/.helm/repository/local
Creating /home/vagrant/.helm/plugins
Creating /home/vagrant/.helm/starters
Creating /home/vagrant/.helm/repository/repositories.yaml
Creating /home/vagrant/.helm/repository/local/index.yaml
$HELM_HOME has been configured at $HOME/.helm.

Tiller (the helm server side component) has been installed into your Kubernetes Cluster.
Happy Helming!
[vagrant@k8s-01 ~]$ kubectl get pods -n kube-system
NAME                             READY     STATUS    RESTARTS   AGE
dnsmasq-j2p0d                    1/1       Running   1          1m
flannel-k8s-01                   1/1       Running   2          22s
kube-apiserver-k8s-01            1/1       Running   1          1m
kube-controller-manager-k8s-01   1/1       Running   1          1m
kube-proxy-k8s-01                1/1       Running   2          22s
kube-scheduler-k8s-01            1/1       Running   1          1m
kubedns-5xmhb                    2/3       Running   1          49s
tiller-deploy-1815933476-s4w1b   1/1       Running   0          13s

[vagrant@k8s-01 ~]$ docker --version
Docker version 1.13.1, build 092cba3

[vagrant@k8s-01 ~]$ cat /etc/redhat-release
CentOS Linux release 7.3.1611 (Core)

@retr0h retr0h mentioned this pull request Mar 1, 2017
@mattymo mattymo merged commit 0e9ad8f into kubernetes-sigs:master Mar 2, 2017
@retr0h retr0h deleted the host-vars branch March 2, 2017 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants