Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kjobctl bootstrap #2307

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Kjobctl bootstrap #2307

merged 2 commits into from
Jun 10, 2024

Conversation

vladikkuzn
Copy link
Contributor

@vladikkuzn vladikkuzn commented May 28, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Introduces initial structure for kjobctl crds and cli

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • Bootstrap kjobctl crds
  • Bootstrap kjobctl cli

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 28, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 28, 2024
@netlify Netlify
Copy link

netlify bot commented May 28, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit f323f5a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6663479e93afea0008d602c6

@vladikkuzn
Copy link
Contributor Author

/assign @vladikkuzn @trasc

@vladikkuzn vladikkuzn changed the title Kjonctl bootstrap Kjobctl bootstrap May 29, 2024
@vladikkuzn vladikkuzn force-pushed the kjob-bootstrap branch 3 times, most recently from 7c0728a to 678a8d2 Compare May 30, 2024 01:01
@vladikkuzn vladikkuzn force-pushed the kjob-bootstrap branch 2 times, most recently from acd4252 to 54fe352 Compare May 31, 2024 00:12
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 2, 2024
mbobrovskyi
mbobrovskyi reviewed Jun 3, 2024
View reviewed changes
cmd/experimental/kjobctl/hack/update-codegen.sh Outdated
# Generating conversion and defaults functions
kube::codegen::gen_helpers \
--boilerplate ${KJOBCTL_ROOT}/hack/boilerplate.go.txt \
"${KJOBCTL_ROOT}/apis/v1alpha1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"${KJOBCTL_ROOT}/apis/v1alpha1"
"${KJOBCTL_ROOT}"

I'm wondering, is it possible to set like this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely it will result just in parsing extra files that are not relevant for the generator.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but the same situation with kube::codegen::gen_client

trasc
trasc reviewed Jun 4, 2024
View reviewed changes
cmd/experimental/kjobctl/PROJECT Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/README.md Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/README.md Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/README.md Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/README.md Outdated
- kubectl version v1.11.3+.
- Access to a Kubernetes v1.11.3+ cluster.

### To Deploy on the cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### To Deploy on the cluster
### To prepare the cluster

Maybe

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not need in our case

cmd/experimental/kjobctl/config/rbac/kustomization.yaml Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/config/rbac/service_account.yaml Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/config/samples/kueue.experimental_v1alpha1_volumebundle.yaml Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/config/samples/kustomization.yaml Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/hack/update-codegen.sh Outdated
# Generating conversion and defaults functions
kube::codegen::gen_helpers \
--boilerplate ${KJOBCTL_ROOT}/hack/boilerplate.go.txt \
"${KJOBCTL_ROOT}/apis/v1alpha1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely it will result just in parsing extra files that are not relevant for the generator.

@mbobrovskyi mbobrovskyi force-pushed the kjob-bootstrap branch 2 times, most recently from 381bf96 to ba804f3 Compare June 5, 2024 15:32
@mbobrovskyi
Copy link
Contributor

/test all

@trasc
Copy link
Contributor

trasc commented Jun 6, 2024

Overall LGTM

@mbobrovskyi
Copy link
Contributor

/assign @alculquicondor

alculquicondor
alculquicondor reviewed Jun 7, 2024
View reviewed changes
cmd/experimental/kjobctl/README.md Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/README.md Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/apis/v1alpha1/volumebundle_types.go Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/apis/v1alpha1/volumebundle_types.go Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/go.mod Outdated Show resolved Hide resolved
cmd/experimental/kjobctl/README.md Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the kjob-bootstrap branch 2 times, most recently from 368f618 to 2375ac6 Compare June 7, 2024 17:29
@mbobrovskyi
Copy link
Contributor

/test all

@mbobrovskyi
Copy link
Contributor

/test all

@vladikkuzn vladikkuzn marked this pull request as ready for review June 10, 2024 12:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2024
alculquicondor
alculquicondor reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b73332c73db9d3c1db8f0a188e292e17fda32d2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit aa88d0e into kubernetes-sigs:main Jun 10, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jun 10, 2024
@vladikkuzn vladikkuzn deleted the kjob-bootstrap branch June 11, 2024 08:59
Fiona-Waters pushed a commit to Fiona-Waters/kueue that referenced this pull request Jun 25, 2024
@vladikkuzn @mbobrovskyi @Fiona-Waters
Kjobctl bootstrap (kubernetes-sigs#2307)
e569a5a 
* Kjonctl bootstrap

* [Kjobctl] Bootstrap application.

---------

Co-authored-by: Mykhailo Bobrovskyi <mikhail.bobrovsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasc trasc trasc left review comments

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@IrvingMg IrvingMg Awaiting requested review from IrvingMg

@mwielgus mwielgus Awaiting requested review from mwielgus

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@alculquicondor alculquicondor

@vladikkuzn vladikkuzn

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
6 participants
@vladikkuzn @k8s-ci-robot @mbobrovskyi @trasc @alculquicondor @mwielgus