-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add port-forward logic with PortForward and ClusterPortForward type #233
add port-forward logic with PortForward and ClusterPortForward type #233
Conversation
✅ Deploy Preview for k8s-kwok canceled.
|
Welcome @nikola-jokic! |
Hi @nikola-jokic. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
2ff740f
to
8a33f44
Compare
/retest |
I tried to figure out why are tests failing, but when I try them on the main branch, the same output is shown. |
It doesn't seem to be an effect of this work, so you can ignore it for now. |
Based on my patch of comments, following these steps seems to be working. IMAGE_PREFIX=local make build build-image
./bin/$(go env GOOS)/$(go env GOARCH)/kwokctl create cluster --config port-forwrd.yaml
kubectl config use-context kwok-kwok
kubectl apply -f ./test/kwokctl/fake-node.yaml
kubectl apply -f ./test/kwokctl/fake-deployment.yaml
kubectl port-forward deployment/fake-pod 8080:10247
curl 127.0.0.1:8080 # port-forwrd.yaml
kind: ClusterPortForward
apiVersion: kwok.x-k8s.io/v1alpha1
metadata:
name: cluster-port-forward-rules
spec:
forwards:
- targetPort: 10247
targetAddress: localhost |
I would like to make the matching capability a bit more generic, there are 3 other configurations that need to reuse this part, unit tests for this, and e2e just need to test that the features work properly. |
7554c17
to
d90efa2
Compare
/retest |
ad365a0
to
1f79bf4
Compare
b77e909
to
2a42fd9
Compare
Co-authored-by: Nikola Jokic <jokicnikola07@gmail.com>
765eaae
to
10eebe4
Compare
Co-authored-by: Nikola Jokic <jokicnikola07@gmail.com>
10eebe4
to
8b4e16c
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikola-jokic, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes #216
Special notes for your reviewer:
Not sure exactly how to test this change so I am creating this as a draft for further comments☺️ I was able to fake it by passing --config with configuration from the issue
Does this PR introduce a user-facing change?