Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

HNC: propagate.hnc.x-k8s.io/select won't trigger object propagation on newly labelled namespaces #1448

Closed
yiqigao217 opened this issue Mar 24, 2021 · 2 comments · Fixed by #1488
Assignees
Milestone

Comments

@yiqigao217
Copy link
Contributor

In a namespace hierarchy like this:

a
├── [s] b
└── [s] c

[s] indicates subnamespaces

If a role in the namespace a has

    annotations:
      propagate.hnc.x-k8s.io/select: score.networkpolicy/allow-shared-ingress

, it won't be propagated into b or c if they don't have the score.networkpolicy/allow-shared-ingress label on the namespace.

The issue is that if we now add score.networkpolicy/allow-shared-ingress label to b or c, the object should be propagated to these namespaces. However currently, the object propagation is not triggered unless there's an update on the source object.

We should make sure the object propagation is triggered when the label is added/removed from a child namespace.

@adrianludwin
Copy link
Contributor

Fixed by #1488

/close

@k8s-ci-robot
Copy link
Contributor

@adrianludwin: Closing this issue.

In response to this:

Fixed by #1488

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants