Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

HNC: CannotUpdate conditions might not be cleared in descendants when a hierarchy changes #605

Closed
adrianludwin opened this issue Apr 3, 2020 · 6 comments · Fixed by #632
Closed

HNC: CannotUpdate conditions might not be cleared in descendants when a hierarchy changes #605

adrianludwin opened this issue Apr 3, 2020 · 6 comments · Fixed by #632
Assignees
@adrianludwin @yiqigao217
Milestone
hnc-v0.3

Comments

@adrianludwin
Copy link
Contributor

See #597 (comment)
@adrianludwin adrianludwin self-assigned this Apr 3, 2020
@adrianludwin adrianludwin added this to the hnc-v0.3 milestone Apr 3, 2020
@adrianludwin adrianludwin mentioned this issue Apr 3, 2020
Merged
@adrianludwin
Copy link
Contributor Author

Also consider improving comments based on the linked discussion above.

@adrianludwin
Copy link
Contributor Author

/cc @yiqigao217

LMK if you're able to take this one on when your current PRs are finished

@yiqigao217
Copy link
Contributor

Sure, i will take this one.
/assign @yiqigao217

@yiqigao217
Copy link
Contributor

yiqigao217 commented Apr 6, 2020 •
edited
Loading

Hi, @adrianludwin I was trying to introduce the CannotUpdate condition in my manual test. The only way to introduce this condition is to introduce an error for updating/creating. Is there a way to produce that in a manual test?

@yiqigao217 yiqigao217 mentioned this issue Apr 6, 2020
Merged
@yiqigao217 yiqigao217 mentioned this issue Apr 9, 2020
Merged
@adrianludwin
Copy link
Contributor Author

/reopen

#617 was just the test

@k8s-ci-robot
Copy link
Contributor

@adrianludwin: Reopened this issue.

In response to this:

/reopen

#617 was just the test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Apr 9, 2020
GinnyJI added a commit to GinnyJI/multi-tenancy that referenced this issue Jul 21, 2020
@GinnyJI
Add e2e test for clearing CannotUpdate conditions in descendants when a
3bb3094 
hierachy changes

Convert test for issue kubernetes-retired#605 to issue_test.go

Tested: make e2e-test
@GinnyJI GinnyJI mentioned this issue Jul 21, 2020
Merged
GinnyJI added a commit to GinnyJI/multi-tenancy that referenced this issue Jul 21, 2020
@GinnyJI
Add e2e test for clearing CannotUpdate conditions in descendants when a
66454de 
hierachy changes

Convert test for issue kubernetes-retired#605 to issue_test.go

Tested: make e2e-test
GinnyJI added a commit to GinnyJI/multi-tenancy that referenced this issue Jul 21, 2020
@GinnyJI
Add e2e test for clearing CannotUpdate conditions in descendants when a
3772bce 
hierachy changes

Convert test for issue kubernetes-retired#605 to issue_test.go

Tested: make e2e-test
GinnyJI added a commit to GinnyJI/multi-tenancy that referenced this issue Jul 22, 2020
@GinnyJI
Add test for issue kubernetes-retired#605
c74672c
GinnyJI added a commit to GinnyJI/multi-tenancy that referenced this issue Jul 22, 2020
@GinnyJI
Add test for issue kubernetes-retired#605
b554d0c
@adrianludwin adrianludwin mentioned this issue Sep 18, 2020
Merged
@adrianludwin adrianludwin mentioned this issue Apr 27, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adrianludwin adrianludwin

@yiqigao217 yiqigao217

Labels
None yet
Projects
None yet
Milestone
hnc-v0.3
Development

Successfully merging a pull request may close this issue.

Flush obsolete conditions on descendants yiqigao217/multi-tenancy
3 participants
@k8s-ci-robot @adrianludwin @yiqigao217