Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

[MTB] changed flag name -t to --as #938

Merged
merged 3 commits into from
Jul 26, 2020
Merged

[MTB] changed flag name -t to --as #938

merged 3 commits into from
Jul 26, 2020

Conversation

phoenixking25
Copy link
Contributor

/assign @JimBugwadia

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @phoenixking25. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 26, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2020
JimBugwadia
JimBugwadia suggested changes Jul 26, 2020
View reviewed changes
benchmarks/kubectl-mtb/internal/kubectl-mtb/test.go Outdated
@@ -214,8 +214,8 @@ func runTests(cmd *cobra.Command, args []string) error {
}

func newTestCmd() *cobra.Command {
testCmd.Flags().StringP("namespace", "n", "", "name of tenant-admin namespace")
testCmd.Flags().StringP("tenant-admin", "t", "", "name of tenant service account")
testCmd.Flags().StringP("namespace", "n", "", "name of tenantnamespace")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change text help to, tenant namespace

benchmarks/kubectl-mtb/internal/kubectl-mtb/test.go Outdated
testCmd.Flags().StringP("namespace", "n", "", "name of tenant-admin namespace")
testCmd.Flags().StringP("tenant-admin", "t", "", "name of tenant service account")
testCmd.Flags().StringP("namespace", "n", "", "name of tenantnamespace")
testCmd.Flags().String("as", "", "Username to impersonate the tenant-admin/user")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change help text to, user name to impersonate

benchmarks/kubectl-mtb/internal/kubectl-mtb/test.go Outdated
testCmd.Flags().StringP("namespace", "n", "", "name of tenant-admin namespace")
testCmd.Flags().StringP("tenant-admin", "t", "", "name of tenant service account")
testCmd.Flags().StringP("namespace", "n", "", "name of tenantnamespace")
testCmd.Flags().String("as", "", "Username to impersonate the tenant-admin/user")
testCmd.Flags().StringP("out", "o", "default", "output reporter format")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change help text to, output reporters (default, policyreport)

benchmarks/kubectl-mtb/internal/kubectl-mtb/test.go Outdated
testCmd.Flags().StringP("namespace", "n", "", "name of tenant-admin namespace")
testCmd.Flags().StringP("tenant-admin", "t", "", "name of tenant service account")
testCmd.Flags().StringP("namespace", "n", "", "name of tenantnamespace")
testCmd.Flags().String("as", "", "Username to impersonate the tenant-admin/user")
testCmd.Flags().StringP("out", "o", "default", "output reporter format")
testCmd.Flags().StringP("skip", "s", "", "skips the benchmarks using ID")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change help text to, (optional) benchmark IDs to skip

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2020
@JimBugwadia
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2020
@JimBugwadia
Copy link
Contributor

@phoenixking25 - please mark prior items as resolved, when completed

@JimBugwadia
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JimBugwadia, phoenixking25

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7115622 into kubernetes-retired:master Jul 26, 2020
@phoenixking25 phoenixking25 mentioned this pull request Jul 27, 2020
Closed
@phoenixking25 phoenixking25 mentioned this pull request Aug 23, 2020
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JimBugwadia JimBugwadia JimBugwadia requested changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@tashimi tashimi Awaiting requested review from tashimi

Assignees

@JimBugwadia JimBugwadia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phoenixking25 @k8s-ci-robot @JimBugwadia