Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not make -delete-extra-tags imply -garbage-collect #16

Closed
listx opened this issue Feb 23, 2019 · 4 comments
Closed

Do not make -delete-extra-tags imply -garbage-collect #16

listx opened this issue Feb 23, 2019 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@listx
Copy link
Contributor

listx commented Feb 23, 2019

This is because we want to separate promoter runs from garbage collection runs.

Separation of concerns ftw!
@listx listx added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 23, 2019
@hpandeycodeit
Copy link

@listx I am interested in this one. Any pointers to start with ?

@listx
Copy link
Contributor Author

listx commented Feb 23, 2019

Hi @hpandeycodeit !

I think it's as simple as removing the if-block at https://github.com/GoogleCloudPlatform/k8s-container-image-promoter/blob/master/cip.go#L57 and also updating any related help text in that file.

@hpandeycodeit hpandeycodeit mentioned this issue Feb 24, 2019
Merged
@listx
Copy link
Contributor Author

listx commented Mar 18, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@listx: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@listx @k8s-ci-robot @hpandeycodeit