Removed code for deleteExtraTags #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
listx
reviewed
Feb 25, 2019
cip.go
Outdated
| @@ -46,18 +46,14 @@ func main() { | |||
| "delete-extra-tags", | |||
| false, | |||
| "delete tags in the destination registry that are not declared"+ | |||
| " in the Manifest (default: false); implies -garbage-collect") | |||
| " in the Manifest (default: false);") | |||
There was a problem hiding this comment.
Please also delete the trailing semicolon
|
Also please reword your commit text like this: See https://chris.beams.io/posts/git-commit/ for additional guidance. |
|
@listx I removed the semicolon but somehow rewording the first commit isn't working. Let me know if you want me to create a new PR? |
|
You can just |
hpandeycodeit
force-pushed
the
issue_16
branch
from
44e139d
to
18d4c0d
Compare
hpandeycodeit
force-pushed
the
issue_16
branch
from
18d4c0d
to
063b8ee
Compare
|
@listx I just did it. Let me know if it looks good to you. Thank you! |
|
Awesome, thank you! |
|
@listx Thank you! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed code for deleteExtraTags where it was causing garbage collection.
Issue #16