-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SignContainerIdentity
option
#220
Add support for SignContainerIdentity
option
#220
Conversation
github.com/sigstore/cosign/v2 v2.0.3-0.20230517070756-fc61f43262cb | ||
github.com/sigstore/cosign/v2 v2.0.3-0.20230614173616-4a2f67e796b9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can either wait for a new release here or just go ahead as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are planning to cut a release soon, maybe today :)
187b7cd
to
6fe16bc
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After the merge of sigstore/cosign#2984, we now can use the new option to support it within the release-sdk as well. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
6fe16bc
to
07136be
Compare
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
After the merge of sigstore/cosign#2984, we now can use the new option to support it within the release-sdk as well.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?