Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tools and set require go1.21 as minimum #100

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 28, 2024

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

  • bump tools and set require go1.21 as minimum

/hold for test-infra job update to go1.22

/assign @saschagrunert @puerco @ameukam
cc @kubernetes-sigs/release-engineering

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 28, 2024
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2024
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2024
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@cpanato
Copy link
Member Author

cpanato commented Mar 29, 2024

drop eneable checks

WARN [linters_context] gocritic: no need to enable check "appendAssign": it's already enabled
WARN [linters_context] gocritic: no need to enable check "argOrder": it's already enabled
WARN [linters_context] gocritic: no need to enable check "assignOp": it's already enabled
WARN [linters_context] gocritic: no need to enable check "badCall": it's already enabled
WARN [linters_context] gocritic: no need to enable check "badCond": it's already enabled
WARN [linters_context] gocritic: no need to enable check "captLocal": it's already enabled
WARN [linters_context] gocritic: no need to enable check "caseOrder": it's already enabled
WARN [linters_context] gocritic: no need to enable check "codegenComment": it's already enabled
WARN [linters_context] gocritic: no need to enable check "commentFormatting": it's already enabled
WARN [linters_context] gocritic: no need to enable check "defaultCaseOrder": it's already enabled
WARN [linters_context] gocritic: no need to enable check "deprecatedComment": it's already enabled
WARN [linters_context] gocritic: no need to enable check "dupArg": it's already enabled
WARN [linters_context] gocritic: no need to enable check "dupBranchBody": it's already enabled
WARN [linters_context] gocritic: no need to enable check "dupCase": it's already enabled
WARN [linters_context] gocritic: no need to enable check "dupSubExpr": it's already enabled
WARN [linters_context] gocritic: no need to enable check "elseif": it's already enabled
WARN [linters_context] gocritic: no need to enable check "exitAfterDefer": it's already enabled
WARN [linters_context] gocritic: no need to enable check "flagDeref": it's already enabled
WARN [linters_context] gocritic: no need to enable check "flagName": it's already enabled
WARN [linters_context] gocritic: no need to enable check "ifElseChain": it's already enabled
WARN [linters_context] gocritic: no need to enable check "mapKey": it's already enabled
WARN [linters_context] gocritic: no need to enable check "newDeref": it's already enabled
WARN [linters_context] gocritic: no need to enable check "offBy1": it's already enabled
WARN [linters_context] gocritic: no need to enable check "regexpMust": it's already enabled
WARN [linters_context] gocritic: no need to enable check "singleCaseSwitch": it's already enabled
WARN [linters_context] gocritic: no need to enable check "sloppyLen": it's already enabled
WARN [linters_context] gocritic: no need to enable check "sloppyTypeAssert": it's already enabled
WARN [linters_context] gocritic: no need to enable check "switchTrue": it's already enabled
WARN [linters_context] gocritic: no need to enable check "typeSwitchVar": it's already enabled
WARN [linters_context] gocritic: no need to enable check "underef": it's already enabled
WARN [linters_context] gocritic: no need to enable check "unlambda": it's already enabled
WARN [linters_context] gocritic: no need to enable check "unslice": it's already enabled
WARN [linters_context] gocritic: no need to enable check "valSwap": it's already enabled
WARN [linters_context] gocritic: no need to enable check "wrapperFunc": it's already enabled

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Apr 2, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit fed3875 into kubernetes-sigs:main Apr 2, 2024
4 checks passed
@cpanato cpanato deleted the updates branch April 2, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants