Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module version support if tool is installed via go install. #29

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Feb 7, 2022

Signed-off-by: Scott Nichols n3wscott@chainguard.dev

What type of PR is this?

/kind feature

What this PR does / why we need it:

Version is not set correctly if the cli tool is installed via go install. Go has a mechanism for surfacing this info inside the debug state struct. This wires that info together with our versions if it is present.

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2022
@puerco
Copy link
Member

puerco commented Feb 7, 2022

Thanks a lot @n3wscott ! This will make looking up versions in our tools much easier.
(^^ take a look @kfaseela, coming soon to bom )

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 625caeb into kubernetes-sigs:main Feb 7, 2022
@n3wscott n3wscott deleted the add-debug-version branch February 7, 2022 18:00
@kfaseela
Copy link

kfaseela commented Feb 7, 2022

Thanks a lot @n3wscott ! This will make looking up versions in our tools much easier. (^^ take a look @kfaseela, coming soon to bom )

/lgtm

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants