Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename verison.go -> version.go #30

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Rename verison.go -> version.go #30

merged 1 commit into from
Feb 7, 2022

Conversation

puerco
Copy link
Member

@puerco puerco commented Feb 7, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Small PR to rename version/verison.go to version/version.go

Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Can you hear me now?

Does this PR introduce a user-facing change?

NONE

@puerco
Rename verison.go -> version.go
164e79c 
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 7, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2022
n3wscott
n3wscott approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

whoops! nice catch :D

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit fb81325 into kubernetes-sigs:main Feb 7, 2022
@puerco puerco deleted the rename branch February 7, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott approved these changes

@onlydole onlydole Awaiting requested review from onlydole

@sethmccombs sethmccombs Awaiting requested review from sethmccombs

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puerco @k8s-ci-robot @n3wscott