Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to CheckGitConfigExists #35

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Minor improvements to CheckGitConfigExists #35

merged 1 commit into from
Feb 8, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Feb 8, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR introduces minor improvements to the CheckGitConfigExists target:

  • Add a comment describing why we ignore errors from git config
  • Use RunSilentSuccessOutput to avoid printing/leaking name and email on stdout
  • Do not return an error because it's always nil

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?

NONE

/assign @saschagrunert @cpanato @puerco @palnabarun
cc @kubernetes-sigs/release-engineering

@xmudrii
Minor improvements to CheckGitConfigExists
3250ae8 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2022
saschagrunert
saschagrunert approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit eb1b073 into kubernetes-sigs:main Feb 8, 2022
@xmudrii xmudrii deleted the improve-check-gitconfig branch February 8, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@mkorbi mkorbi Awaiting requested review from mkorbi

Assignees

@saschagrunert saschagrunert

@puerco puerco

@cpanato cpanato

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xmudrii @k8s-ci-robot @saschagrunert @puerco @cpanato @palnabarun