Drop compat for go < 1.17 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies our mage go verification step to drop compatibility with go < 1.17 when checking modules. It also enables an env var `MIN_GO_VERSION` to allow users of the package to configure the go version they require. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
sig/release
k8s-ci-robot
added
approved
Run go mod tidy with the new options to allow this OR to verify itself. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
k8s-ci-robot
added
size/M
justaugustus
approved these changes
Apr 5, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR modifies our mage go verification step to drop
compatibility with go < 1.17 when checking modules. It also
enables an env var
MIN_GO_VERSIONto allow users of thepackage to configure the go version they require.
Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
/assign @justaugustus @cpanato @Verolop
Does this PR introduce a user-facing change?