Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate SPCPS targetPaths match Pod UIDs #371

Merged
merged 1 commit into from
Nov 3, 2020
Merged

fix: validate SPCPS targetPaths match Pod UIDs #371

merged 1 commit into from
Nov 3, 2020

Conversation

tam7t
Copy link
Contributor

@tam7t tam7t commented Oct 29, 2020

Consolidated duplicate GetMountedFiles and GetPodUIDFromTargetPath as well.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @tam7t. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2020
aramase
aramase reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

controllers/secretproviderclasspodstatus_controller.go Outdated Show resolved Hide resolved
pkg/errors/errors.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2020
@aramase
Copy link
Member

aramase commented Oct 30, 2020 •
edited
Loading

/retitle fix: validate SPCPS targetPaths match Pod UIDs

@k8s-ci-robot k8s-ci-robot changed the title targetPath: validate SPCSP targetPaths match Pod UIDs fix: validate SPCSP targetPaths match Pod UIDs Oct 30, 2020
@aramase
Copy link
Member

aramase commented Oct 30, 2020

/retitle fix: validate SPCPS targetPaths match Pod UIDs

@k8s-ci-robot k8s-ci-robot changed the title fix: validate SPCSP targetPaths match Pod UIDs fix: validate SPCPS targetPaths match Pod UIDs Oct 30, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2020
@tam7t tam7t requested review from ritazh and aramase October 30, 2020 22:27
aramase
aramase reviewed Nov 2, 2020
View reviewed changes
controllers/secretproviderclasspodstatus_controller.go Outdated Show resolved Hide resolved
controllers/secretproviderclasspodstatus_controller.go Outdated Show resolved Hide resolved
controllers/secretproviderclasspodstatus_controller.go Outdated Show resolved Hide resolved
pkg/rotation/reconciler.go Outdated Show resolved Hide resolved
pkg/secrets-store/nodeserver.go Outdated Show resolved Hide resolved
aramase
aramase reviewed Nov 2, 2020
View reviewed changes
pkg/util/k8sutil/volume.go Outdated Show resolved Hide resolved
aramase
aramase reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tam7t Just one small nit. Otherwise lgtm!

Could you also squash the commits?

@tam7t
fix: validate SPCPS targetPaths match Pod UIDs
c2cbb19 
Consolidated duplicate GetMountedFiles and GetPodUIDFromTargetPath as
well.

Apply suggestions from code review

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>

fix: include a check on volume name matches the targetPath

k8sutil: refactor common func SPCVolume
@tam7t
Copy link
Contributor Author

tam7t commented Nov 2, 2020

@tam7t Just one small nit. Otherwise lgtm!

Could you also squash the commits?

Done!

@aramase
Copy link
Member

aramase commented Nov 2, 2020

/test pull-secrets-store-csi-driver-e2e-windows

aramase
aramase reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2020
@ritazh
Copy link
Member

ritazh commented Nov 3, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ritazh, tam7t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1fa6ffe into kubernetes-sigs:master Nov 3, 2020
@tam7t tam7t mentioned this pull request Nov 6, 2020
Closed
6 tasks
@tam7t tam7t deleted the tam7t/targetPath branch November 10, 2020 23:02
@tam7t tam7t mentioned this pull request Nov 10, 2020
Closed
@tam7t tam7t mentioned this pull request Apr 14, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase left review comments

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tam7t @k8s-ci-robot @aramase @ritazh